Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let getwork/submitwork same as ETH interface. #268

Closed
betachen opened this Issue Mar 14, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@betachen
Copy link
Member

commented Mar 14, 2018

Let getwork/submitwork same as ETH interface.
Then MVS can share ETH pool as well.

chengzhpchn added a commit that referenced this issue Apr 17, 2018

@chengzhpchn

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2018

  1. make alias for command getwork/submitwork as eth_getWork/eth_submitWork;
  2. the new rpc interface corresponding to url: "http://127.0.0.1:8820/rpc/v3";
  3. refer to eth_submitWork JSON API introduction: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_submitwork, Note: the Nonce parameter is started with "0x", which is different with the original MVS submitwork API.

the testcase is also added in:
test/test-rpc/online_testcase/test_work.py

@chengzhpchn

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2018

this feature has been published with Super Nova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.