New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanji learning progress review improvements #386

Closed
GoogleCodeExporter opened this Issue Mar 14, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Collaborator

GoogleCodeExporter commented Mar 14, 2015

- Show kanji details on kanji click
- Ability to view multiple jlpt levels, can be done with ranged seekbar 
http://range-seek-bar.googlecode.com/files/screenshot3.png or with simple 
checkboxes
- Sorting by stroke order, reading etc
- Tip at the top should be hideable, maybe better use an alert with a checkbox 
"don't show again", or an actionbar action "help"
- Not only JLPT, but Jouyou, Heisig etc, probably better use same ui logic as 
in word search (Advanced search settings)

Original issue reported on code.google.com by kazufuku...@gmail.com on 9 Dec 2014 at 9:57

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Sure, this makes sense. Just regarding the "sorting" requirement - can you 
please post a small story on why this feature is important to you? I'm just 
curious; also, I wish to see some justification of a feature before I implement 
it.

Original comment by martin.v...@gmail.com on 17 Dec 2014 at 4:12

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Sure, this makes sense. Just regarding the "sorting" requirement - can you 
please post a small story on why this feature is important to you? I'm just 
curious; also, I wish to see some justification of a feature before I implement 
it.

Original comment by martin.v...@gmail.com on 17 Dec 2014 at 4:12

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Implemented 1. and 4.

Original comment by martin.v...@gmail.com on 17 Dec 2014 at 8:23

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Implemented 1. and 4.

Original comment by martin.v...@gmail.com on 17 Dec 2014 at 8:23

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Sorting will help to locate concrete kanji in the big grid. 機 will be 
somewhere at the end of grid if I sort by stroke count. 会 will be at the 
beginning if I sort by by kunyomi. Maybe I'm bad at kanji with しょう onyomi 
and I will see solid block of red kanji if I sort. BTW which is default 
sorting? it looks random.

Original comment by kazufuku...@gmail.com on 17 Dec 2014 at 8:29

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Sorting will help to locate concrete kanji in the big grid. 機 will be 
somewhere at the end of grid if I sort by stroke count. 会 will be at the 
beginning if I sort by by kunyomi. Maybe I'm bad at kanji with しょう onyomi 
and I will see solid block of red kanji if I sort. BTW which is default 
sorting? it looks random.

Original comment by kazufuku...@gmail.com on 17 Dec 2014 at 8:29

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Implemented 2. and 5., sorting will be implemented in next version

Original comment by martin.v...@gmail.com on 18 Dec 2014 at 9:18

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Implemented 2. and 5., sorting will be implemented in next version

Original comment by martin.v...@gmail.com on 18 Dec 2014 at 9:18

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Just thinking: if a kanji has multiple readings, which one should I pick for 
sorting? I may pick a random one, or all, but there is no good strategy to 
group e.g. kanjis with the しょう onyomi... Let us think about this more.
Meanwhile, I will implement the occurence- and stroke- based ordering.

Original comment by martin.v...@gmail.com on 28 Dec 2014 at 10:14

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Just thinking: if a kanji has multiple readings, which one should I pick for 
sorting? I may pick a random one, or all, but there is no good strategy to 
group e.g. kanjis with the しょう onyomi... Let us think about this more.
Meanwhile, I will implement the occurence- and stroke- based ordering.

Original comment by martin.v...@gmail.com on 28 Dec 2014 at 10:14

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator

Original comment by martin.v...@gmail.com on 28 Dec 2014 at 11:29

  • Changed state: Fixed
Collaborator

GoogleCodeExporter commented Mar 14, 2015

Original comment by martin.v...@gmail.com on 28 Dec 2014 at 11:29

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
I think the only way is to separate onyomi and kunyomi and use first, usually 
the most used reading.

Original comment by kazufuku...@gmail.com on 31 Dec 2014 at 11:54

Collaborator

GoogleCodeExporter commented Mar 14, 2015

I think the only way is to separate onyomi and kunyomi and use first, usually 
the most used reading.

Original comment by kazufuku...@gmail.com on 31 Dec 2014 at 11:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment