New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starts-with does not match exact words #402

Closed
GoogleCodeExporter opened this Issue Mar 14, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Collaborator

GoogleCodeExporter commented Mar 14, 2015

I have a problem with Aedict which started from a recent update. If I have
my search filter settings to match the start of a word, it will not match
exact matches as well. For example, when I search for 近所, the actual entry
for that word will not show up unless I change the settings to exact match.

Would it be possible to go back to the original way of matching so that
exact matches also come up when searching with starts with?

Original issue reported on code.google.com by martin.v...@gmail.com on 24 Dec 2014 at 7:22

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Works for me (please see attached screenshots). Please attach your screenshots, 
to demonstrate the issue on your phone. You can create screenshots easily, by 
long-pressing the power button and the volume down button.

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 9:16

  • Changed state: CantReproduce

Attachments:

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Works for me (please see attached screenshots). Please attach your screenshots, 
to demonstrate the issue on your phone. You can create screenshots easily, by 
long-pressing the power button and the volume down button.

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 9:16

  • Changed state: CantReproduce

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Sorry about this. When taking the screenshots, I saw that the search type was 
set to Verbs. I've never intentionally used that filter before, so my eyes 
always skipped right over it. 

However, take a look at the attached screenshots as there seems to be a 
different problem. 

When Verbs is selected, 近所 will appear when "match exact" but not when 
"match starts."

近所 isn't a verb, so it shouldn't appear either way.




Original comment by jacobhic...@gmail.com on 25 Dec 2014 at 9:33

Attachments:

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Sorry about this. When taking the screenshots, I saw that the search type was 
set to Verbs. I've never intentionally used that filter before, so my eyes 
always skipped right over it. 

However, take a look at the attached screenshots as there seems to be a 
different problem. 

When Verbs is selected, 近所 will appear when "match exact" but not when 
"match starts."

近所 isn't a verb, so it shouldn't appear either way.




Original comment by jacobhic...@gmail.com on 25 Dec 2014 at 9:33

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Yes, I noticed this behavior too. Obviously, 近所 is not a verb per se, so 
Aedict should display 0 results. However, when 0 results are found, a fallback 
sentence analysis kicks in, which will try to split the "近所" sentence into 
separate words, and it succeeds - it finds exactly one word, 近所.

This needs three fixes:

1. an information that only verbs are being searched for;
2. if the analysis fallback returns only one word, discard it;
3. otherwise, add an information that analysis fallback has been performed.

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 11:49

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Yes, I noticed this behavior too. Obviously, 近所 is not a verb per se, so 
Aedict should display 0 results. However, when 0 results are found, a fallback 
sentence analysis kicks in, which will try to split the "近所" sentence into 
separate words, and it succeeds - it finds exactly one word, 近所.

This needs three fixes:

1. an information that only verbs are being searched for;
2. if the analysis fallback returns only one word, discard it;
3. otherwise, add an information that analysis fallback has been performed.

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 11:49

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 11:49

  • Changed state: Started
Collaborator

GoogleCodeExporter commented Mar 14, 2015

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 11:49

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 12:28

  • Changed state: Fixed
Collaborator

GoogleCodeExporter commented Mar 14, 2015

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 12:28

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Sentence analysis mode ignores filter settings such as "Type", "Common only" 
and "JLPT".

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 12:31

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Sentence analysis mode ignores filter settings such as "Type", "Common only" 
and "JLPT".

Original comment by martin.v...@gmail.com on 25 Dec 2014 at 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment