New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "Send as flashcard" directly on the action bar #422

Closed
GoogleCodeExporter opened this Issue Mar 14, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Collaborator

GoogleCodeExporter commented Mar 14, 2015

Currently, the "Send as flashcard" button is hidden under an extra click on the 
"Dot-dot-dot" button in the action bar.
I use that button all the time :)

It would be fantastic if you would consider making it show on the actionbar 
(showAsAction="ifRoom").

(PS: Thanks for the most awesome and fantastic app ever!)

Original issue reported on code.google.com by adi.vel...@gmail.com on 5 Feb 2015 at 12:02

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Hi, thank you very much for your praise and sorry for such a late reply :)
Actually, the "Send as flashcard" is marked as "ifRoom", it's just that it's 
positioned after all other actions (add to notepad, tag, copy to clipboard) so 
it overflows into the menu overflow. Try rotating your phone, or try running 
Aedict on a tablet - the "Send as flasbcard" action should be shown again.

The Android guidelines state that the most-used item should be available first, 
but Android provide no support for this. And, manually reordering menu items is 
kinda tricky...

Original comment by martin.v...@gmail.com on 9 Feb 2015 at 10:24

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Hi, thank you very much for your praise and sorry for such a late reply :)
Actually, the "Send as flashcard" is marked as "ifRoom", it's just that it's 
positioned after all other actions (add to notepad, tag, copy to clipboard) so 
it overflows into the menu overflow. Try rotating your phone, or try running 
Aedict on a tablet - the "Send as flasbcard" action should be shown again.

The Android guidelines state that the most-used item should be available first, 
but Android provide no support for this. And, manually reordering menu items is 
kinda tricky...

Original comment by martin.v...@gmail.com on 9 Feb 2015 at 10:24

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Thanks for your reply.

I see! Indeed it does show up if I rotate my phone.

Perhaps consider marking truly often-clicked actions (search, add to notepad, 
tag, copy to clipboard, send as flashcard) as "ifRoom", settings-y actions (Max 
columns, show kana/romaji) as "never", and add a resource override for 
high-resolution screens where these five actions are marked as "always"? :) On 
my nexus 6 (with a decent horizontal resolution) I'm sure more buttons could 
fit. Attaching screenshot

Original comment by adi.vel...@gmail.com on 9 Feb 2015 at 10:40

Attachments:

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Thanks for your reply.

I see! Indeed it does show up if I rotate my phone.

Perhaps consider marking truly often-clicked actions (search, add to notepad, 
tag, copy to clipboard, send as flashcard) as "ifRoom", settings-y actions (Max 
columns, show kana/romaji) as "never", and add a resource override for 
high-resolution screens where these five actions are marked as "always"? :) On 
my nexus 6 (with a decent horizontal resolution) I'm sure more buttons could 
fit. Attaching screenshot

Original comment by adi.vel...@gmail.com on 9 Feb 2015 at 10:40

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Actually, the "max columns" has been set as "never", exactly because it is 
clicked rarely (this will be available in next Aedict). The "show kana/romaji" 
can be hidden in Settings, UI Tuning, Show Romaji/Kana button.
I have looked at the ActionBar/Menu API and there is no way of forcing how many 
actions are shown. So, "always" is the only way.
I could use different menu resources here ( it is actually possible, to my 
surprise: 
http://stackoverflow.com/questions/13045879/android-different-menu-resources ) 
but the menu here is assembled from multiple menu items and it is not easy to 
do.
But, I have a suggestion: Since Aedict 3.9, in the entry list, you can slide a 
dictionary entry item to the left, to reveal quick item actions: 
add_to_notepad, tag and copy-to-clipboard. How about I add the fourth item, 
send-as-flashcard, to this menu? So, instead of clicking on the item to reveal 
entry details and then clicking three-dot menu and send-as-flashcard, you could 
simply slide the item and click send-as-flashcard directly?

Original comment by martin.v...@gmail.com on 9 Feb 2015 at 11:44

Collaborator

GoogleCodeExporter commented Mar 14, 2015

Actually, the "max columns" has been set as "never", exactly because it is 
clicked rarely (this will be available in next Aedict). The "show kana/romaji" 
can be hidden in Settings, UI Tuning, Show Romaji/Kana button.
I have looked at the ActionBar/Menu API and there is no way of forcing how many 
actions are shown. So, "always" is the only way.
I could use different menu resources here ( it is actually possible, to my 
surprise: 
http://stackoverflow.com/questions/13045879/android-different-menu-resources ) 
but the menu here is assembled from multiple menu items and it is not easy to 
do.
But, I have a suggestion: Since Aedict 3.9, in the entry list, you can slide a 
dictionary entry item to the left, to reveal quick item actions: 
add_to_notepad, tag and copy-to-clipboard. How about I add the fourth item, 
send-as-flashcard, to this menu? So, instead of clicking on the item to reveal 
entry details and then clicking three-dot menu and send-as-flashcard, you could 
simply slide the item and click send-as-flashcard directly?

Original comment by martin.v...@gmail.com on 9 Feb 2015 at 11:44

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
I had no idea you could slide a result item to reveal those buttons! Very
cool and very useful. If you add send-as-flashcard there, it would be
great. Looking forward to your next release.

Original comment by adi.vel...@gmail.com on 9 Feb 2015 at 1:42

Collaborator

GoogleCodeExporter commented Mar 14, 2015

I had no idea you could slide a result item to reveal those buttons! Very
cool and very useful. If you add send-as-flashcard there, it would be
great. Looking forward to your next release.

Original comment by adi.vel...@gmail.com on 9 Feb 2015 at 1:42

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 14, 2015

Collaborator
Fixed, should be available in next Aedict.

Original comment by martin.v...@gmail.com on 9 Feb 2015 at 3:18

  • Changed state: Fixed
Collaborator

GoogleCodeExporter commented Mar 14, 2015

Fixed, should be available in next Aedict.

Original comment by martin.v...@gmail.com on 9 Feb 2015 at 3:18

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment