New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrelated search result #471

Closed
siritinga opened this Issue Apr 5, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@siritinga

Hi.
I'm not sure if there is something wrong here. When I search for "eru" using exact match, I'm getting an unrelated result (doesn't contain eru): 九死. It seems that it is found in the romaji text, because searching for える does not return it. The definition doesn't seem to contain eru.

@mvysny mvysny added the bug label Apr 6, 2015

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Apr 6, 2015

Owner

This is a long-standing bug which perhaps finally deserved to be fixed ;) The problem is that the "eru" term is being searched in all translations of the entry. The 九死 entry in particular has the following definition:

{kanji=[九死], reading=[きゅうし], senses=[[n]{deu=[(f) Situation, die man sehr wahrscheinlich nicht überleben wird (häufig in der Wendung kyūshi ni isshō o eru = dem Tod mit knapper Not entkommen)], eng=[narrowly averting death]}]}

So, as we can see, the "eru" term is present in the german translation, but not in the english translation, which will be confusing to english users which do not have the german translation shown. I need to fix both the dictionary files and the search engine, to search only in user's configured language (with fallback to EN or DE in case of Wadoku).

Owner

mvysny commented Apr 6, 2015

This is a long-standing bug which perhaps finally deserved to be fixed ;) The problem is that the "eru" term is being searched in all translations of the entry. The 九死 entry in particular has the following definition:

{kanji=[九死], reading=[きゅうし], senses=[[n]{deu=[(f) Situation, die man sehr wahrscheinlich nicht überleben wird (häufig in der Wendung kyūshi ni isshō o eru = dem Tod mit knapper Not entkommen)], eng=[narrowly averting death]}]}

So, as we can see, the "eru" term is present in the german translation, but not in the english translation, which will be confusing to english users which do not have the german translation shown. I need to fix both the dictionary files and the search engine, to search only in user's configured language (with fallback to EN or DE in case of Wadoku).

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Apr 10, 2015

Owner

Fixed; the fix will be available when Aedict 3.16 is released and dictionaries newer than 1.May 2015 are used.

Owner

mvysny commented Apr 10, 2015

Fixed; the fix will be available when Aedict 3.16 is released and dictionaries newer than 1.May 2015 are used.

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny May 4, 2015

Owner

Please make sure that you have Aedict 3.16 or newer installed, then head to Settings / Dictionaries / Dictionary Manager and update all dictionaries. I have just today released a new bunch of dictionaries which should now return only relevant results.
Please reopen if the issue is not fixed.

Owner

mvysny commented May 4, 2015

Please make sure that you have Aedict 3.16 or newer installed, then head to Settings / Dictionaries / Dictionary Manager and update all dictionaries. I have just today released a new bunch of dictionaries which should now return only relevant results.
Please reopen if the issue is not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment