-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching a word doesn't show it is added to notepad #488
Comments
Fixed in Aedict 3.19 |
I'm afraid this fix creates a problem in the opposite direction... |
You're right, thanks for letting me know. Perhaps I need to find a matching rule which is neither as strict as in Aedict 3.17, nor as relaxed as in Aedict 3.18 :-) |
I can't name entries from the top of my head, but I'll think about it. Explanation is OK. Now, I have noticed that matching is really relaxed, as it also matches entries from other dictionaries :-). In my opinion, dictionaries should also be matched, not just kanji and readings. |
Maybe you can use "ent_seq" field from the jmdict file to match entries added to notepad? The following is from this page
So, even though this doesn't cover merges/deletions, it is probably a better solution than matching only kanji/readings. As for other dictionaries, I don't know if they have something like this... |
There are lots of dictionaries in old EDICT format (e.g. Buddha Term Dictionary, Car dictionary etc) which do not contain the 'ent_seq' parameter. Also, current notepad entries do not contain such ID so you would have to clear the notepad and populate it again. So, unfortunately the ent_seq idea is very good but cannot be used I believe. |
What about the following: if the dictionary doesn't have 'ent_seq' parameter, compare kanji and pronunciation. If the dictionary does have 'ent_seq', use it if it stored in notepad (for newly added entries), else use backup strategy of comparing kanji and pronunciation. Now, since currently notepad entries don't contain 'ent_seq', there could be several options to provide this field: there could be an option to start an automatic process to compare data stored in notepad entries with data from the dictionary, and only if everything matches (I think like the method used in version 3.16), to save 'ent_seq' to each notepad entry. This would probably fill quite a lot of entries at the moment. Those entries which are not matched could be marked somehow (an icon if enabled in options?), and there could be another option to provide this information manually for people who need this. This might be too complicated for a regular user, but I suppose there would be some people how would use this (well, at least one :-) ). |
Hmm, that sounds complicated ;) I am going to release a quick-fix version of Aedict 3.20. How about I implement the 'easy' solution (the entries will match if they share at least one common kanji AND one common reading) and we will see how this will work in real life. |
Well, that's certainly better than the current solution... Don't forget to also match the dictionary. |
Thanks, I will do that. Closing this bug, please feel free to post if you find more of the incorrectly matched entries. |
In version 3.20, there is no longer a problem with 方, however, there is still cross-dictionary matching, so words from different dictionaries are shown with notepad icon, even though only one entry is added to notepad. |
Thanks, you're right - I will additionally match the dictionaries. |
Just to avoid misunderstandings, apart from matching the dictionaries there is the additional problem of falsely matching entries which doesn't have kanji (only kana) - e.g. the above mentioned "akagire" - "hibi". |
Thanks! I have implemented a stricter version of the match algorithm which correctly no longer match akagire from JMDict and hibi from Live Sciences (I have implemented the dictionary origin matching, but also the algorithm got stricter and would not match akagire/hibi even if they would originate from the same dictionary). Please wait for Aedict 3.21 to get released, then please let me know if there are still more entries which match incorrectly. |
I use aedict version 3.16, and I have noticed a strange thing. I was searching for a word. When the dictionary listed it in the results screen, it was not marked with the notepad icon. However I was sure that it has already been added to notepad. Then I found this word in the notepad. When I returned to the start screen with recent words, I could see two entries with the same word - one added to notepad, and other without notepad icon (see picture below). By looking at them it is obvious that they are not completely the same, although they both come from the same dictionary. It looks like that the word stored in notepad was copied from the dictionary, and in the meantime the dictionary has been updated. Now I can't know for sure if the word I'm searching for is in the notepad or not...
Is it possible to update the notepad entry when the dictionary is updated? Or do you have some other suggestion?
The text was updated successfully, but these errors were encountered: