Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: search by heisig #500

Closed
bengaskin opened this issue May 7, 2015 · 3 comments
Closed

suggestion: search by heisig #500

bengaskin opened this issue May 7, 2015 · 3 comments
Labels

Comments

@bengaskin
Copy link

@bengaskin bengaskin commented May 7, 2015

I'm very glad the app includes heisig kanji names and numbers. But how about including a search by heisig name and search by heisig index number?
Incidentally even the main search ignores heisig names completely... try searching for nightbreak for example (no results found). Thanks!

@mvysny mvysny added the enhancement label May 8, 2015
@mvysny
Copy link
Owner

@mvysny mvysny commented May 8, 2015

Good idea, thanks! I will include heisig keywords and heisig numbers into the index, so if you write either the heisig keyword or the heisig number into the omnisearch box, appropriate entries will be found.

@mvysny
Copy link
Owner

@mvysny mvysny commented May 8, 2015

Implemented, will be available automatically when dictionaries are updated (next scheduled dictionary update: June 1st 2015). Just a reminder: you will need to search in Kanjidic, not in JMDict.

@mvysny mvysny closed this May 8, 2015
@bengaskin
Copy link
Author

@bengaskin bengaskin commented May 8, 2015

OK great, thanks!

Ben
On May 8, 2015 9:18 PM, "Martin Vysny" notifications@github.com wrote:

Implemented, will be available automatically when dictionaries are updated
(next scheduled dictionary update: June 1st 2015). Just a reminder: you
will need to search in Kanjidic, not in JMDict.

Reply to this email directly or view it on GitHub
#500 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.