New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set priority of dictionaries #502

Closed
timrae opened this Issue May 11, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@timrae

timrae commented May 11, 2015

If I enable the names dictionary in addition to the standard dictionary, then searching for sushi (寿司) leads to the first 3 hits being people's names. I'd like to either have the standard dictionary be hard-coded to have a higher priority than the others, or for there to be some setting where we can set the priority.

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny May 11, 2015

Owner

During sentence analysis JMDict always has the highest priority, because other dictionaries produced weird results ;)
However, during regular search, I thought that dictionaries enabled by user should have higher priority than JMDict (user enabled the dictionary after all, and he wants to perform search in it). However, you may be right that sometimes it is preferred to search in JMDict first. I will add a search setting for this.

Owner

mvysny commented May 11, 2015

During sentence analysis JMDict always has the highest priority, because other dictionaries produced weird results ;)
However, during regular search, I thought that dictionaries enabled by user should have higher priority than JMDict (user enabled the dictionary after all, and he wants to perform search in it). However, you may be right that sometimes it is preferred to search in JMDict first. I will add a search setting for this.

@mvysny mvysny added the enhancement label May 11, 2015

@timrae

This comment has been minimized.

Show comment
Hide comment
@timrae

timrae May 11, 2015

I'm not sure, but I would think in general most people are using the other
dictionaries as a supplement to JMDict...? I'd think in general we only
want to see those results when necessary (i.e. when there is no result in
JMDict).

On Mon, May 11, 2015 at 5:50 PM, Martin Vysny notifications@github.com
wrote:

During sentence analysis JMDict always has the highest priority, because
other dictionaries produced weird results ;)
However, during regular search, I thought that dictionaries enabled by
user should have higher priority than JMDict (user enabled the dictionary
after all, and he wants to perform search in it). However, you may be right
that sometimes it is preferred to search in JMDict first. I will add a
search setting for this.


Reply to this email directly or view it on GitHub
#502 (comment).

timrae commented May 11, 2015

I'm not sure, but I would think in general most people are using the other
dictionaries as a supplement to JMDict...? I'd think in general we only
want to see those results when necessary (i.e. when there is no result in
JMDict).

On Mon, May 11, 2015 at 5:50 PM, Martin Vysny notifications@github.com
wrote:

During sentence analysis JMDict always has the highest priority, because
other dictionaries produced weird results ;)
However, during regular search, I thought that dictionaries enabled by
user should have higher priority than JMDict (user enabled the dictionary
after all, and he wants to perform search in it). However, you may be right
that sometimes it is preferred to search in JMDict first. I will add a
search setting for this.


Reply to this email directly or view it on GitHub
#502 (comment).

@timrae

This comment has been minimized.

Show comment
Hide comment
@timrae

timrae May 11, 2015

At least for my usage case, I've enabled the names dictionary to supplement
JMDICT sentence analysis, and that has kind of screwed up my ordinary
search.

On Mon, May 11, 2015 at 5:56 PM, Tim Rae perceptualchaos2@gmail.com wrote:

I'm not sure, but I would think in general most people are using the other
dictionaries as a supplement to JMDict...? I'd think in general we only
want to see those results when necessary (i.e. when there is no result in
JMDict).

On Mon, May 11, 2015 at 5:50 PM, Martin Vysny notifications@github.com
wrote:

During sentence analysis JMDict always has the highest priority, because
other dictionaries produced weird results ;)
However, during regular search, I thought that dictionaries enabled by
user should have higher priority than JMDict (user enabled the dictionary
after all, and he wants to perform search in it). However, you may be right
that sometimes it is preferred to search in JMDict first. I will add a
search setting for this.


Reply to this email directly or view it on GitHub
#502 (comment).

timrae commented May 11, 2015

At least for my usage case, I've enabled the names dictionary to supplement
JMDICT sentence analysis, and that has kind of screwed up my ordinary
search.

On Mon, May 11, 2015 at 5:56 PM, Tim Rae perceptualchaos2@gmail.com wrote:

I'm not sure, but I would think in general most people are using the other
dictionaries as a supplement to JMDict...? I'd think in general we only
want to see those results when necessary (i.e. when there is no result in
JMDict).

On Mon, May 11, 2015 at 5:50 PM, Martin Vysny notifications@github.com
wrote:

During sentence analysis JMDict always has the highest priority, because
other dictionaries produced weird results ;)
However, during regular search, I thought that dictionaries enabled by
user should have higher priority than JMDict (user enabled the dictionary
after all, and he wants to perform search in it). However, you may be right
that sometimes it is preferred to search in JMDict first. I will add a
search setting for this.


Reply to this email directly or view it on GitHub
#502 (comment).

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny May 11, 2015

Owner

I see. So perhaps I will always set JMDict to go first, and if someone complains, then I will add the setting for the dictionary ordering.

Owner

mvysny commented May 11, 2015

I see. So perhaps I will always set JMDict to go first, and if someone complains, then I will add the setting for the dictionary ordering.

@timrae

This comment has been minimized.

Show comment
Hide comment
@timrae

timrae May 11, 2015

Yeah I think that's reasonable. Just to confirm, the priority would be as
follows, right?

Words tagged with (P) in JMDict
Words tagged with (P) in user dicts
Other words in JMDict
Other words in user dicts

On Mon, May 11, 2015 at 5:59 PM, Martin Vysny notifications@github.com
wrote:

I see. So perhaps I will always set JMDict to go first, and if someone
complains, then I will add the setting for the dictionary ordering.


Reply to this email directly or view it on GitHub
#502 (comment).

timrae commented May 11, 2015

Yeah I think that's reasonable. Just to confirm, the priority would be as
follows, right?

Words tagged with (P) in JMDict
Words tagged with (P) in user dicts
Other words in JMDict
Other words in user dicts

On Mon, May 11, 2015 at 5:59 PM, Martin Vysny notifications@github.com
wrote:

I see. So perhaps I will always set JMDict to go first, and if someone
complains, then I will add the setting for the dictionary ordering.


Reply to this email directly or view it on GitHub
#502 (comment).

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny May 11, 2015

Owner

Currently the order is as follows (P) user dicts, other user dicts, (P) JMDict, other JMDict. I can reorder the results as you request though, no problem.

Owner

mvysny commented May 11, 2015

Currently the order is as follows (P) user dicts, other user dicts, (P) JMDict, other JMDict. I can reorder the results as you request though, no problem.

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny May 13, 2015

Owner

Fixed in Aedict 3.19

Owner

mvysny commented May 13, 2015

Fixed in Aedict 3.19

@mvysny mvysny closed this May 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment