New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis Sentences #512

Closed
boku0801 opened this Issue Jun 5, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@boku0801

boku0801 commented Jun 5, 2015

When a sentences is clicked on, it does not go to the analysis tab immediately, it first opens up the same sentence without the analysis in a new page...this seems like a wasted click. Can it be made so sentences clicked on go immediately to the analysis page?

Thank you.

@mvysny mvysny added the enhancement label Jun 6, 2015

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jun 6, 2015

Owner

Sure, good idea. Alternatively, the sentence analysis tab can be merged with the first tab and the analysis could be shown below the sentence detail, what do you think?

Owner

mvysny commented Jun 6, 2015

Sure, good idea. Alternatively, the sentence analysis tab can be merged with the first tab and the analysis could be shown below the sentence detail, what do you think?

@boku0801

This comment has been minimized.

Show comment
Hide comment
@boku0801

boku0801 Jun 6, 2015

Thanks for the reply.

The alternative seems to be fine, but only if it does not impose the
furigana readings on the user (provides am option to immediately switch it
on/off). This is to maintain the option of the user having to choose to
test their knowledge of the kanji, as well as to switch between checking
that knowledge.

Thank you.

2015年6月6日(土) 1:56 Martin Vysny notifications@github.com:

Sure, good idea. Alternatively, the sentence analysis tab can be merged

with the first tab and the analysis could be shown below the sentence
detail, what do you think?


Reply to this email directly or view it on GitHub
#512 (comment).

boku0801 commented Jun 6, 2015

Thanks for the reply.

The alternative seems to be fine, but only if it does not impose the
furigana readings on the user (provides am option to immediately switch it
on/off). This is to maintain the option of the user having to choose to
test their knowledge of the kanji, as well as to switch between checking
that knowledge.

Thank you.

2015年6月6日(土) 1:56 Martin Vysny notifications@github.com:

Sure, good idea. Alternatively, the sentence analysis tab can be merged

with the first tab and the analysis could be shown below the sentence
detail, what do you think?


Reply to this email directly or view it on GitHub
#512 (comment).

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jun 10, 2015

Owner

Fixed in Aedict 3.24, please reopen if this is not according to your requirements. This 'first tab split between the sentence and analysis' mode will be activated by default, to deactivate, just head to Settings / GUI Tuning / Dictionary Entry and uncheck "Sentence Analysis in first tab"

Owner

mvysny commented Jun 10, 2015

Fixed in Aedict 3.24, please reopen if this is not according to your requirements. This 'first tab split between the sentence and analysis' mode will be activated by default, to deactivate, just head to Settings / GUI Tuning / Dictionary Entry and uncheck "Sentence Analysis in first tab"

@mvysny mvysny closed this Jun 10, 2015

@boku0801

This comment has been minimized.

Show comment
Hide comment
@boku0801

boku0801 Jun 13, 2015

This is what I had in mind. Thanks you.

boku0801 commented Jun 13, 2015

This is what I had in mind. Thanks you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment