New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to remove the results from the kanjipad screen #530

Closed
blastrock opened this Issue Jun 24, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@blastrock

blastrock commented Jun 24, 2015

Hi,

Just above the pad part of the kanjipad screen, there are buttons, and I can't see all of them on my phone. More importantly, the last button (which resets the pad) does not appear at all when I hold my phone vertically. I have the same problem (though I see more of the buttons) with a small tablet I have.

I saw that, on smaller screens, the kanjipad would take a greater part of the screen, and the result are shown at the top of the screen. I think the same layout should be kept for screens a little bigger than that. And the best thing would be to add an option in the settings to force one layout or the other as people prefer.

That would also help me draw the kanjis since it's easier to have aedict recognize the kanjis if I can draw it better on a bigger pad.

Other than that, aedict is a nice soft, keep up the good work :)

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jul 1, 2015

Owner

Hi, thanks for letting me know. Can you please post the exact sizes (both inch and pixels) of both of your phone and your tablet? I will then run Aedict in the emulator and I will fix this. Thanks!

Owner

mvysny commented Jul 1, 2015

Hi, thanks for letting me know. Can you please post the exact sizes (both inch and pixels) of both of your phone and your tablet? I will then run Aedict in the emulator and I will fix this. Thanks!

@blastrock

This comment has been minimized.

Show comment
Hide comment
@blastrock

blastrock Jul 1, 2015

My phone is a nexus 5 with a 1920x1080 screen on which I changed the DPI setting to 360 dpi, which means the virtual size of the screen 6.12 inches. The real size (though I don't think it matters here) is 4.95 inches.

The tablet is a lenovo a3000 which does not have any fancy setting, it has a resolution of 600x1024 and a size of 7 inches.

blastrock commented Jul 1, 2015

My phone is a nexus 5 with a 1920x1080 screen on which I changed the DPI setting to 360 dpi, which means the virtual size of the screen 6.12 inches. The real size (though I don't think it matters here) is 4.95 inches.

The tablet is a lenovo a3000 which does not have any fancy setting, it has a resolution of 600x1024 and a size of 7 inches.

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jul 2, 2015

Owner

You're right, on 7" tablet in portrait mode the button is chopped and there is little room for the kanjipad:
device-2015-07-02-102708

Owner

mvysny commented Jul 2, 2015

You're right, on 7" tablet in portrait mode the button is chopped and there is little room for the kanjipad:
device-2015-07-02-102708

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jul 2, 2015

Owner

Fixed; 7" tablet in portrait mode will use the same layout as a small phone does. The two-column-with-search-results mode will only be used on 7" tablets when they are in the landscape mode.
Cannot verify the fix on Nexus5 though as changing the DPI AFAIK requires rooting of the phone. Marking as fixed, please let me know if the problem is fixed also on your Nexus 5 phone.
Fixed in Aedict 3.27

Owner

mvysny commented Jul 2, 2015

Fixed; 7" tablet in portrait mode will use the same layout as a small phone does. The two-column-with-search-results mode will only be used on 7" tablets when they are in the landscape mode.
Cannot verify the fix on Nexus5 though as changing the DPI AFAIK requires rooting of the phone. Marking as fixed, please let me know if the problem is fixed also on your Nexus 5 phone.
Fixed in Aedict 3.27

@mvysny mvysny closed this Jul 2, 2015

@blastrock

This comment has been minimized.

Show comment
Hide comment
@blastrock

blastrock Jul 2, 2015

Yes it is, thank you!

blastrock commented Jul 2, 2015

Yes it is, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment