New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrogation marks break the search in aedict #607

Closed
nake90 opened this Issue Jan 13, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@nake90

nake90 commented Jan 13, 2016

Hi all,

When searching some text that has interrogation marks ('?') in it the whole text is skipped and no results are returned.

This is most probably because of the new search mechanic added a few updates ago that allowed to search for incomplete sentences by using the '?' character if I'm not mistaken. But it is extremely inconvenient when used with aedict-reader because no results show up at all when for example I'm having a conversation in LINE and I don't understand a question they asked me. In that case I have to minimize, open aedict, paste there the text and delete the question mark manually.

The solution I propose is to delete the special characters from the text to search in aedict-reader before sending it to the search engine, or adding a mode to aedict that when the search comes from the reader the special characters are not used as such.

Thank you very much in advance!

@mvysny mvysny added the bug label Jan 13, 2016

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jan 13, 2016

Owner

Thanks for pointing this out. You're right - when the query contains ?* then probably the sentence analysis is accidentally turned off. Let me look at this.

Owner

mvysny commented Jan 13, 2016

Thanks for pointing this out. You're right - when the query contains ?* then probably the sentence analysis is accidentally turned off. Let me look at this.

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jan 18, 2016

Owner

This issue was present in Aedict itself, rather than in the Aedict Reader. I have fixed this in Aedict 3.39.5, please be patient until the upgrade is released.

Owner

mvysny commented Jan 18, 2016

This issue was present in Aedict itself, rather than in the Aedict Reader. I have fixed this in Aedict 3.39.5, please be patient until the upgrade is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment