Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in Aedict API when Aedict has no dictionaries downloaded #664

Closed
dpasca opened this issue Apr 21, 2016 · 6 comments
Closed

Crash in Aedict API when Aedict has no dictionaries downloaded #664

dpasca opened this issue Apr 21, 2016 · 6 comments
Labels
bug

Comments

@dpasca
Copy link

@dpasca dpasca commented Apr 21, 2016

Upon clipboard copy, the popup stays up with a spinning wheel while a termination dialog comes up.
I’ve sent a couple of automatic reports.
This is on a Note 5 with 5.1.1 . First time user.
Thanks.

@mvysny
Copy link
Owner

@mvysny mvysny commented Apr 21, 2016

Thank you for the bug report, and I apologize for the crash. I can see the crash in my Google Play console, I'll look at it and I'll let you know.

@mvysny mvysny added the bug label Apr 21, 2016
@mvysny
Copy link
Owner

@mvysny mvysny commented Apr 21, 2016

Hmm, this is weird. Reader asks Aedict to translate stuff, and for some reason, Aedict thinks you have no dictionaries installed locally. Can you please try opening Aedict and performing a couple of searches? Also, Please head to Aedict Settings, Dictionaries, Dictionary Manager, and in the upper-right menu, Dictionary Health Check, to see if there are any reddish text? Thanks!

@dpasca
Copy link
Author

@dpasca dpasca commented Apr 21, 2016

Hi Martin,

Cool ! Mystery solved !
I did buy Aedict3 for the popup service and installed on request, without
actually opening it not even once, so the dictionaries weren’t downloaded.

I guess for a first time users that come straight for the popup, it would
make sense to put an warning dialog suggesting to download the dictionaries.

Anyhow, everything works now, Thanks !
On Apr 21, 2016 4:47 PM, "Martin Vysny" notifications@github.com wrote:

Hmm, this is weird. Reader asks Aedict to translate stuff, and for some
reason, Aedict thinks you have no dictionaries installed locally. Can you
please try opening Aedict and performing a couple of searches? Also, Please
head to Aedict Settings, Dictionaries, Dictionary Manager, and in the
upper-right menu, Dictionary Health Check, to see if there are any reddish
text? Thanks!


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#664 (comment)

@mvysny
Copy link
Owner

@mvysny mvysny commented Apr 21, 2016

I knew there is something weird going on :-D Thank you for letting me know. I will make the Reader Popup show a correct error message instead, perhaps even automatically open Aedict.

@mvysny
Copy link
Owner

@mvysny mvysny commented Apr 21, 2016

Pasting technical crash stack trace from Google Play:

java.lang.RuntimeException: java.lang.IllegalStateException: No JMDicts locally present???
at sk.baka.aedict3.search.SearchService$IncomingHandler$1.onFailure(SearchService.java:79)
at sk.baka.aedict3.util.android.LoaderEx$Loader.onFailure(LoaderEx.java:181)
at sk.baka.aedict3.util.android.LoaderEx$Loader.access$100(LoaderEx.java:105)
at sk.baka.aedict3.util.android.LoaderEx$Loader$1.run(LoaderEx.java:158)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:6897)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)
Caused by: java.lang.IllegalStateException: No JMDicts locally present???
at sk.baka.aedict.search.impl.MultiJMDictSearch$Companion.newSearch(MultiJMDictSearch.kt:65)
at sk.baka.aedict.search.impl.MultiJMDictSearch.newSearch(MultiJMDictSearch.kt)
at sk.baka.aedict.search.JMDictQuery.search(JMDictQuery.java:69)
at sk.baka.aedict3.search.GlobalSearchHandler$QueryLoader.loadItemsInBackground(GlobalSearchHandler.java:133)
at sk.baka.aedict3.util.android.LoaderEx$Loader.run(LoaderEx.java:129)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:818)

@mvysny mvysny changed the title Crash on clipboard copy Reader:Crash on clipboard copy Apr 21, 2016
@mvysny
Copy link
Owner

@mvysny mvysny commented Apr 21, 2016

Fixed in Aedict 3.39.17: if Aedict dictionaries is missing, a single result is provided: "Aedict dictionaries are missing, please start the Aedict application to download them"

@mvysny mvysny closed this Apr 21, 2016
@mvysny mvysny changed the title Reader:Crash on clipboard copy Crash in Aedict API when Aedict has no dictionaries downloaded Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.