Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry detail line break duplicates characters #666

Closed
mvysny opened this issue May 5, 2016 · 16 comments
Closed

Entry detail line break duplicates characters #666

mvysny opened this issue May 5, 2016 · 16 comments

Comments

@mvysny
Copy link
Owner

@mvysny mvysny commented May 5, 2016

Hi, as seen in the attached screenshots, landscape mode looks fine, but in portrait mode, the secondary pronunciation せろんちょうさ seems to have the ちょ appearing twice (once on each line). Actually, I'm not sure the line breaks are needed at all on my screen, especially on the very last reading, where さ is on its own line.
screenshot_2016-05-02-17-08-05

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 5, 2016

Hi Mike,

thank you for the screenshot, I can see the issue. However, this may
be hard to fix - I am only using standard Android formatting patterns
in
a standard Android text component. Therefore, the bug is most probably
present in the Android text component, and there is not much I can do

Yet, please try to disable the Settings / GUI Tuning / Dictionary
Entry Screen / Show Pitch Accent (just set it to "None:") and please
let
me know if this helped.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 5, 2016

Android 4.0.4 on Samsung Galaxy S2, model SPH-D710.

@mvysny mvysny closed this May 5, 2016
@mvysny mvysny reopened this May 5, 2016
@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 5, 2016

Setting "Show Pitch Accent" to "None" fixes the repeated ちょ

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 5, 2016

Hmm, apparently the "overline span" which
indicates the high pitch is the cause of this problem on your phone. I
can not completely fix this issue as I cannot reproduce it on my phone.
However, there are possible workarounds:

  1. simply not showing overline in your phone - only the downstep
    characters (the down arrow) will be shown.
  2. not showing pitch information at all
  3. by showing the middle-pitch not as "overline", but as
    "strikethrough", which should behave correctly but will cause the kana
    to be not as readable.

Please let me know which solution would be acceptable for you.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 5, 2016

Mike: Oh, that's too bad about the overline; I like the overline. But if I had to choose among those three options, I'd choose number 1.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 5, 2016

I'll fix this as follows: I will keep the overline enabled by default, but I will add a new configuration option to Settings / GUI Tuning / Dictionary Entry Screen / Pitch Accent:
Show Mid Pitch: "Mark Mid Pitch characters with" 1. Overline 2. Strike-through 3. Do not mark

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 11, 2016

Added additional setting: Mark with Red Color. Fixed in Aedict 3.39.18

@mvysny mvysny closed this May 11, 2016
@mikemorr
Copy link

@mikemorr mikemorr commented May 11, 2016

The red color seems not to work on my phone (Galaxy S2, Android 4.0.4). I tested it with Holo Light and Holo Dark themes.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 11, 2016

Hmm, this is weird. The red color works correctly on my phone. Does the "Strike-through" option work correctly?

@mvysny mvysny reopened this May 11, 2016
@mikemorr
Copy link

@mikemorr mikemorr commented May 11, 2016

Yes, the strike-through works :)

@mikemorr
Copy link

@mikemorr mikemorr commented May 11, 2016

Interestingly, when I set it to Overline, the overlined kana are white (vs. gray for the low-pitched kana). But when I set it to RedColor, the kana are all gray.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 12, 2016

Hmm, this is crazy - I can see the Red text on my phone no problem. Please make sure that you have Aedict 3.39.19 installed, and please try the Red Text setting again.
This Android fragmentation is really horrible :(

@mikemorr
Copy link

@mikemorr mikemorr commented May 12, 2016

Yes, unfortunately the red text isn't appearing for me in 3.39.19. Video demo: https://youtu.be/s8whnqlu5cU

@mikemorr
Copy link

@mikemorr mikemorr commented May 12, 2016

I'm happy to try any test APKs, if you'd like.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 13, 2016

I probably discovered the cause of this issue. The problem is that I tell the text to be grey, and at the same time I tell it to be red. While HTML can handle it, it seems that some Android can't. I'll devise a workaround.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 16, 2016

Fixed span-related issues (I have been trying to reuse span objects, and Android hates that). Should be fixed in Aedict 3.39.20.

@mvysny mvysny closed this May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.