Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanjipad is sluggish with Kanjipad Ext #669

Closed
mvysny opened this issue May 8, 2016 · 2 comments
Closed

Kanjipad is sluggish with Kanjipad Ext #669

mvysny opened this issue May 8, 2016 · 2 comments
Labels
bug

Comments

@mvysny
Copy link
Owner

@mvysny mvysny commented May 8, 2016

The problem is most probably related to #662 and #665 - I am sorting kanjis by stroke numbers on the UI thread which is bad practice and most probably causes the drawing lag. Why only the paid add-on is affected? This is simply because the internal kanjipad provides less kanjis, therefore they are sorted faster and the lag is not as apparent.

@mvysny mvysny added the bug label May 8, 2016
@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 8, 2016

I have moved most CPU heavy work to a background thread. However, you will only benefit from this if you have phone with at least dual-core CPU.
Going to perform several more optimizations.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented May 9, 2016

Finally switched to RecyclerView and properly reusing views. The UI should now be a lot more responsive. Closing as fixed in Aedict 3.39.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.