Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aedict deinflects to nouns #701

Closed
tyress opened this Issue Sep 25, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@tyress
Copy link

tyress commented Sep 25, 2016

For example, if I put in makenai or まけない, the first result is 巻く、and there is a note on the bottom that says
まけない-まける : I do not do something
まける-まける、まく: I'm able to do something

Seems ok, but it's also repeated for words that can't be conjugated, like nouns 幕 and 膜

@tyress tyress changed the title Inputting an inflected word shows explanation on each translation Inputting an inflected word (mistakenly) shows explanation on each translation Sep 26, 2016

@mvysny mvysny added the bug label Sep 29, 2016

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 29, 2016

That is true, thank you for pointing this out. Unfortunately, the deinflection engine works without access to the dictionary. Therefore the engine does not have information whether the deinflection product actually makes sense or not ;) But, the dictionary matcher engine can take this information in account and filter out non-verb and non-adjective words created with deinflection. I'll look at that.

@mvysny mvysny self-assigned this Sep 20, 2017

@Todew

This comment has been minimized.

Copy link

Todew commented Nov 30, 2017

This still seems to be happening, is there any chance of progress?
Also some verbs are incorrectly deinflected; for example entering either かえって or かえて finds exactly the same verbs (as well as the noun かえる.) From what you said it looks as if this can't be changed, is that correct?

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Dec 7, 2017

Sorry, I had no time to look at this. It's not as straightforward. I thought about just searching for verbs, but what if someone is searching actually for a noun? But I have an idea: search the original term without limitation, and union the search results with the search in verbs for deinflected term. Let me write a couple of tests and play with this.

@mvysny mvysny changed the title Inputting an inflected word (mistakenly) shows explanation on each translation Aedict deinflects to nouns Dec 9, 2017

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Dec 9, 2017

Fixed in Aedict 3.46

@mvysny mvysny closed this Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.