New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request/enhancement - Add support to display content of Jim Breen tags field, xref, and lsource and dial info #717

Closed
terrywallwork opened this Issue Dec 10, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@terrywallwork

terrywallwork commented Dec 10, 2016

I would like to ask for a feature request.

The XML file for Jim Breens Japanese Dictionary file has tag entries to describing the field a particular word comes from and xref (cross reference tags), and Language source tags which indicate which language a word is borrowed from for Japanese loan words, and dialect tags. But it appears that AEDict does not use this information or display the information in the Dictionary interface.

It would be especially useful to have support for xref, field, lsource and dial fields to narrow down ambiguity.

Here is the xml dtd for those tags which give a better explanation than I am able to.

<!-- Information about the field of application of the entry/sense. 
When absent, general application is implied. Entity coding for 
specific fields of application. -->
<!-- This element is used to indicate a cross-reference to another
entry with a similar or related meaning or sense. The content of
this element is typically a keb or reb element in another entry. In some
cases a keb will be followed by a reb and/or a sense number to provide
a precise target for the cross-reference. Where this happens, a JIS
"centre-dot" (0x2126) is placed between the components of the 
cross-reference.
-->
<!-- This element records the information about the source
language(s) of a loan-word/gairaigo. If the source language is other 
than English, the language is indicated by the xml:lang attribute.
The element value (if any) is the source word or phrase.
-->
<!-- The xml:lang attribute defines the language(s) from which
a loanword is drawn.  It will be coded using the three-letter language 
code from the ISO 639-2 standard. When absent, the value "eng" (i.e. 
English) is the default value. The bibliographic (B) codes are used. -->
<!-- The ls_type attribute indicates whether the lsource element
fully or partially describes the source word or phrase of the
loanword. If absent, it will have the implied value of "full".
Otherwise it will contain "part".  -->
<!-- The ls_wasei attribute indicates that the Japanese word
has been constructed from words in the source language, and
not from an actual phrase in that language. Most commonly used to
indicate "waseieigo". -->
<!-- For words specifically associated with regional dialects in
Japanese, the entity code for that dialect, e.g. ksb for Kansaiben.
-->
@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Feb 4, 2017

Owner

Hi, thanks for letting me know, and I apologize for such a late reply. It is true, I am ignoring several metadata from the data files (including those you pointed out). This is on purpose, to avoid information overload, especially for beginners who just started to learn the language.

However, I may implement this in the same way as with Kanjis - so that you could "pin" the information you need, and that information will then be displayed. This would probably be helpful for advanced learners.

Okay then, I'll add this information, both to the dictionary files and to the Aedict UI.

Owner

mvysny commented Feb 4, 2017

Hi, thanks for letting me know, and I apologize for such a late reply. It is true, I am ignoring several metadata from the data files (including those you pointed out). This is on purpose, to avoid information overload, especially for beginners who just started to learn the language.

However, I may implement this in the same way as with Kanjis - so that you could "pin" the information you need, and that information will then be displayed. This would probably be helpful for advanced learners.

Okay then, I'll add this information, both to the dictionary files and to the Aedict UI.

@mvysny mvysny self-assigned this Feb 4, 2017

@mvysny mvysny added the enhancement label Feb 4, 2017

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Feb 14, 2017

Owner

Implemented in 3.39.29, please make sure that the dictionary files are updated.

Owner

mvysny commented Feb 14, 2017

Implemented in 3.39.29, please make sure that the dictionary files are updated.

@mvysny mvysny closed this Feb 14, 2017

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Feb 15, 2017

Owner

Forgot to add xref and field-of-application, reopening.

Owner

mvysny commented Feb 15, 2017

Forgot to add xref and field-of-application, reopening.

@mvysny mvysny reopened this Feb 15, 2017

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Feb 15, 2017

Owner

Ok, added xref and field-of-application. Fixed in Aedict 3.39.29

Owner

mvysny commented Feb 15, 2017

Ok, added xref and field-of-application. Fixed in Aedict 3.39.29

@mvysny mvysny closed this Feb 15, 2017

@terrywallwork

This comment has been minimized.

Show comment
Hide comment
@terrywallwork

terrywallwork Feb 16, 2017

Thanks,

And sorry it took me a while to notice. I will update dictionaries and give it a run :)

terrywallwork commented Feb 16, 2017

Thanks,

And sorry it took me a while to notice. I will update dictionaries and give it a run :)

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Feb 16, 2017

Owner

Hold on please, I first need to release new aedict :) you can download the dictionary updates though, but the info will not be displayed until the new aedict is released

Owner

mvysny commented Feb 16, 2017

Hold on please, I first need to release new aedict :) you can download the dictionary updates though, but the info will not be displayed until the new aedict is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment