Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Tatoeba for しか pulls in examples for Chicago #742

Closed
pt-dev opened this issue Mar 16, 2017 · 4 comments
Closed

Link to Tatoeba for しか pulls in examples for Chicago #742

pt-dev opened this issue Mar 16, 2017 · 4 comments
Assignees
Labels
bug

Comments

@pt-dev
Copy link

@pt-dev pt-dev commented Mar 16, 2017

Search for しか and pick the 'only, nothing but' meaning.
Choose 'Examples'. All the Tatoeba sentences are for Chicago.

I'm aware this could be a Tatoeba bug as well. 😊

@mvysny
Copy link
Owner

@mvysny mvysny commented Mar 17, 2017

Thanks for letting me know. Yeah, Aedict probably tries to be too smart and will also search for hiragana shika, finding a lot about Chicago ;) While this is handy for JMDict, it apparently isn't as handy for example sentences. I'll remove this feature for Example Sentence search.

What puzzles me is that apparently this feature is not used from the main screen search. If you search for しか in the main screen in examples, you won't get any Chicago results.

@mvysny mvysny self-assigned this Mar 17, 2017
@mvysny mvysny added the bug label Mar 17, 2017
@mvysny
Copy link
Owner

@mvysny mvysny commented Apr 2, 2017

Okay, searching for しか in the main screen with searching in Examples will also return countless Chicago-related results :-) Clearly, searching for "shika" should return Chicago-sentences since it must search for both hiragana and katakana. Yet, searching for しか shouldn't match シカ...

@mvysny
Copy link
Owner

@mvysny mvysny commented Apr 2, 2017

Oh, actually perhaps it should: apparently kirei can be written both in hiragana and in katakana, e.g. とてもキレイでした。 It was very beautiful. or なんてキレイな写真なんでしょう。 What a beautiful picture!
Yet I am still inclined to fix this since those Chicago sentences are virtually useless as examples for しか.

@mvysny
Copy link
Owner

@mvysny mvysny commented Apr 2, 2017

device-2017-04-02-202418
Fixed in Aedict 3.39.34

@mvysny mvysny closed this Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.