Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irregular inflections are incorrect #758

Closed
dovej opened this Issue May 3, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@dovej
Copy link

dovej commented May 3, 2017

The current inflections pane seems to run a blind algorithm. As a result, incorrect inflections are displayed for irregular verbs. For example, する→しって, 行く→行いて, etc. くる seems to be special cased, but that's the only one.

Meanwhile, the entries for いい and かっこいい are missing inflections entirely.

While there are a relatively small set of irregularities in Japanese, making exhaustive special-casing feasible, it is worth pointing out that the JMDict web interface has conjugation tables for all of the irregular words and gets them right. So I'm guessing that data is in JMDict itself. It is probably safer and easier to source the base conjugation data from there. More advanced grammatical patterns like 「〜た方がいい」could be constructed by building off the base conjugation data.

JMDict's conjugation for する: http://nihongo.monash.edu/cgi-bin/wwwjdic?1W%B0%D9%A4%EB_vs-i

@dovej

This comment has been minimized.

Copy link
Author

dovej commented May 3, 2017

Hmm... JMDict seems to punt on v5aru like くださる: http://nihongo.monash.edu/cgi-bin/wwwjdic?1W%B2%BC%A4%B5%A4%EB_v5aru The phrasing on that page suggests that it might be supported in the future, which is a point in favor of sourcing conjugation data from JMDict if possible (for the sake of updates).

However, the app Jsho does conjugate v5aru verbs, and based on my very elementary knowledge, it seems to get it right. But I don't know enough to be positive.

In any event, the full JMDict parts-of-speech code table should be consulted when attacking this issue, because the set of irregularities and archaicisms in modern Japanese is larger than people often think. Fortunately, JMDict has already done the heavy lifting by annotating the relevant entries with these codes.

@mvysny mvysny self-assigned this May 13, 2017

@mvysny mvysny added the bug label May 13, 2017

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 19, 2017

Yup, that is true - kuru was the only one inflected in a special way. I have fixed suru #757 , let's fix iku next: http://www.sljfaq.org/cgi/verb-inflect.cgi?verb=iku

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 19, 2017

行く fixed, let's fix v5aru like 下さる: https://en.wikipedia.org/wiki/Japanese_verb_conjugation

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 19, 2017

v5aru fixed; I looked on いい and it's not adj-i nor adj-na so that's why the inflections are missing. I'll add a special inflector for that one.

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 19, 2017

Fixed いい inflection. Fixed in Aedict 3.42, please verify and if the inflections are still off, please open a new bug report. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.