New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang/freeze on lookup of certain kanji from Reader Popup #775

Closed
mikemorr opened this Issue Jul 1, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@mikemorr

mikemorr commented Jul 1, 2017

Aedict 3.39.39, dark theme, on Android 6.0.1.

Steps to reproduce:

Enable "Watch Clipboard" feature in Aedict Reader.

Copy the kanji 慇 or 懃 to the clipboard, causing the Aedict Reader Popup to appear with an explanation of the kanji as expected.

Tap the popup to reveal its tabs/buttons.

Tap the top left tab/button (Aedict あ icon) for "Show words in Aedict".

Observed behavior: Phone screen says "Aedict Search" and nothing else. Phone hangs / becomes sluggish.

@mvysny mvysny self-assigned this Jul 2, 2017

@mvysny mvysny added the bug label Jul 2, 2017

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jul 2, 2017

Owner

Good catch, thanks! I wonder what is causing this behaviour. It seems that fetching the example sentences takes a long time; and Aedict blocks until those are fetched. Unfortunately, one can't just simply do profiling on such a retarded development platform which Android is beyond doubt; one just have to add more logging until the performance bottleneck becomes apparent.

Owner

mvysny commented Jul 2, 2017

Good catch, thanks! I wonder what is causing this behaviour. It seems that fetching the example sentences takes a long time; and Aedict blocks until those are fetched. Unfortunately, one can't just simply do profiling on such a retarded development platform which Android is beyond doubt; one just have to add more logging until the performance bottleneck becomes apparent.

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Jul 2, 2017

Owner

Actually the issue was in the kanji->kana reading matcher in Aedict. Optimized, fixed in Aedict 3.40

Owner

mvysny commented Jul 2, 2017

Actually the issue was in the kanji->kana reading matcher in Aedict. Optimized, fixed in Aedict 3.40

@mvysny mvysny closed this Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment