Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pronounce button reading pitchless hiragana readings only #778

Closed
tyress opened this issue Jul 16, 2017 · 5 comments
Closed

Pronounce button reading pitchless hiragana readings only #778

tyress opened this issue Jul 16, 2017 · 5 comments
Assignees
Labels
bug

Comments

@tyress
Copy link

@tyress tyress commented Jul 16, 2017

Would be great if it read the Kanji directly as I think (I think) pitch is automatically taken into account with TTS. Currently the popular Hashi (箸 and 橋) are pronounced the same.

@mvysny
Copy link
Owner

@mvysny mvysny commented Jul 17, 2017

That is true - TTS is currently given the reading only; since the TTS engine ignores pitch markings it will read it quite flat. The advantage is that it will read all readings. If the TTS engine was given only the kanji, then it would read just the first reading.
Perhaps if I let the TTS to read the kanji first, then the readings, that would do the trick? Not sure here, perhaps it will confuse the user even more.

Perhaps the best idea is to allow the user to choose what will be sent to the TTS engine - either kanji, or reading.

@tyress
Copy link
Author

@tyress tyress commented Jul 17, 2017

I think it's okay to get the kanji part read first, but personally I think it might sound good to get to choose? It's rare, but 執行 (しっこう, etc.)for example has four readings and the output seems like a good demonstration of why being to choose might be great :)

@mvysny
Copy link
Owner

@mvysny mvysny commented Jul 17, 2017

I think I remember now: when I introduced TTS, the engines back then were way simpler and couldn't handle reading kanjis. However it seems that the situation has been improved now. I'll thus add support for the picker on what to read.

@mvysny
Copy link
Owner

@mvysny mvysny commented Jul 17, 2017

Selection dialog implemented in Aedict 3.41. It seems that the TTS still have some issues, at least the default Google one, since it reads 喰べる as something like 'kviberu' ;) Anyways, at least now you can choose what the TTS will read.

Don't trust the TTS too much - albeit the speech synthesis made huge progress, it is still just an automatized tool which may make mistakes.

@mvysny mvysny closed this Jul 17, 2017
@tyress
Copy link
Author

@tyress tyress commented Aug 8, 2017

It's awesome by the way, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.