Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate related terms #779

Closed
mikemorr opened this issue Jul 19, 2017 · 5 comments
Closed

Duplicate related terms #779

mikemorr opened this issue Jul 19, 2017 · 5 comments
Assignees
Labels
bug

Comments

@mikemorr
Copy link

@mikemorr mikemorr commented Jul 19, 2017

In this screenshot, お見事 shows two related terms 見事 1 and 見事 2, but they appear to be identical. I wonder if this is the desired behavior? Perhaps it is a redundancy in the dictionary data?
screenshot_20170718-222823

@mvysny
Copy link
Owner

@mvysny mvysny commented Jul 19, 2017

That's how JMDict lists them:

<entry>
<ent_seq>2235980</ent_seq>
<k_ele>
<keb>お見事</keb>
</k_ele>
<k_ele>
<keb>お美事</keb>
</k_ele>
<r_ele>
<reb>おみごと</reb>
</r_ele>
<info>
<audit>
<upd_date>2007-11-18</upd_date>
<upd_detl>Entry created</upd_detl>
</audit>
</info>
<sense>
<pos>&int;</pos>
<xref>見事・1</xref>
<xref>見事・2</xref>
<gloss>well done!</gloss>
<gloss>bravo</gloss>
</sense>
</entry>

Quoting the documentation of the xref element:

This element is used to indicate a cross-reference to another
entry with a similar or related meaning or sense. The content of
this element is typically a keb or reb element in another entry. In some
cases a keb will be followed by a reb and/or a sense number to provide
a precise target for the cross-reference. Where this happens, a JIS
"centre-dot" (0x2126) is placed between the components of the
cross-reference.

@mvysny
Copy link
Owner

@mvysny mvysny commented Jul 19, 2017

So, the dot reference targets both first reading, and second reading. If there is some way how this can be improved, please let me know.

@mvysny mvysny self-assigned this Jul 19, 2017
@mikemorr
Copy link
Author

@mikemorr mikemorr commented Jul 20, 2017

Here is a screenshot after tapping the related terms link. Maybe when the references point to the same dictionary entry, the entry could be listed only once, instead of twice as seen here?

screenshot_20170719-215724

Alternatively, it would be neat to somehow highlight the specific sense or senses that are targeted (in this case I guess that would be 1:"splendid, magnificent..." and 2:"praiseworthy act..." but not 3:"utter (esp. defeat)...". But I'm not sure how exactly that would work.

@mvysny
Copy link
Owner

@mvysny mvysny commented Jul 20, 2017

Unfortunately, it is currently impossible to target a particular kanji or particular reading in an entry. I will thus make sure that the entry will appear only once

@mvysny mvysny added bug and removed user feedback needed labels Jul 20, 2017
@mvysny
Copy link
Owner

@mvysny mvysny commented Jul 20, 2017

Fixed in Aedict 3.41

@mvysny mvysny closed this Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.