Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word of the Day #781

Closed
andrejrenard opened this Issue Jul 23, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@andrejrenard
Copy link

andrejrenard commented Jul 23, 2017

Very nice feature.
But would it be possible to open Aedict on this word when clicking on it?

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Jul 24, 2017

Ah true, that makes sense. Currently the original functionality is probably there, which simply launches the Aedict search screen.

@mvysny mvysny self-assigned this Jul 24, 2017

@mvysny mvysny added the enhancement label Jul 24, 2017

@andrejrenard

This comment has been minimized.

Copy link
Author

andrejrenard commented Jul 24, 2017

Can you change the font size for the title and the word. I would rather prefer greater kanjis.
Or perhaps:
Word of the Day: {word}
{translation} {(grammar)}

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Aug 5, 2017

Changing the font size requires custom layouts (as per https://stackoverflow.com/questions/24320601/how-to-style-notification-message-for-pushnotification ), however custom layouts are only supported from Android 7 (sdk 24) which is a no-no for Aedict (because of #741 ). So I can only change the notification title and text as you suggest.

Regarding the navigation: historically, Aedict opened the search screen when clicking the notification. I'd like to preserve that for backwards compatibility. I'll thus add a setting for this - checking this option will cause Aedict to open the word of the day instead of the search screen.

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 18, 2017

Added a setting which, when checked, will make Aedict open the Word Of The Day details. You can find the setting in Settings / GUI Tuning / Notification opens Word Of The Day.

Implemented in Aedict 3.42

@mvysny mvysny closed this Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.