Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notepad deletes random item on delete when sorted by reading #793

Closed
otax38 opened this Issue Aug 29, 2017 · 14 comments

Comments

Projects
None yet
2 participants
@otax38
Copy link

otax38 commented Aug 29, 2017

Hi Martin,

For memory, the bug we discussed already :

I made recently a mistake in my Notepads.
So I tried to transfer an item from one Notepad to another with the "Move to Category" option.
It went well in the destination, but not at the original Notepad in the sens that it remains.
As a result, my word is now in 2 Notepads.
So I tried the "Delete selected" in the same options menu, but it did nothing, and remains.

Settings
In user data, my choice was : Notepad : Add Unique Only, so it is strange It could duplicate when moving.
In expert settings, I think i am quite regular (no use of SD Card Storage, only internal memory) File-based option.

Thanks,
Regards,
JPierre.

@mvysny mvysny self-assigned this Sep 5, 2017

@mvysny mvysny added the bug label Sep 5, 2017

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 12, 2017

Hi, thanks for the report and I apologise for the issue. Unfortunately I can't reproduce this issue on my phone - the deletion of selected entries works correctly for me. Can you please create a category and add such entries there so that the bug is easily reproducible? Thanks!

@otax38

This comment has been minimized.

Copy link
Author

otax38 commented Sep 12, 2017

Hi, thanks for trying to solve that.
I am not sure to understand what I can do for helping ...

  1. create a new empty category (OK, understood)
  2. I add only items that are already in my other categories (Notepads) ?
  3. I do that for plenty items and check if some can be erased or not ?

NB : I tried to create a bug report, but my phone doesnt work correctly with Android Device Monitor (device not seen) :-(

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 12, 2017

Basically, since I can't reproduce the issue, you will have to find a smallest set of steps which reproduces the issue. I will then try to repeat those steps and reproduce the issue - if I successfully reproduce the issue on my device that's great since then I can fix it immediately. Thus I was thinking that you should start with an empty category, add couple of items and try to delete them. If the items are not deleted, awesome - we have a reproducible set of steps. If the items are deleted, then please try further ;)

NB : I tried to create a bug report, but my phone doesnt work correctly with Android Device Monitor (device not seen) :-(

Yeah, you'll need to enable the developer mode on your phone. Please see e.g. https://www.greenbot.com/article/2457986/android/how-to-enable-developer-options-on-your-android-phone-or-tablet.html for more details

@otax38

This comment has been minimized.

Copy link
Author

otax38 commented Sep 12, 2017

OK, understood, thanks.

NB: developer mode was activated (I tried under Windows and Linux, but both couldnt see my phone)
Problem must be between chair and keyboard ^^

@otax38

This comment has been minimized.

Copy link
Author

otax38 commented Sep 12, 2017

For the moment, all my attempts cannot reproduce the bug also ! (create, move, erase, all OK)
I must find the items that I couldn't erase and try again.
The problem is to find them (I didn't pay attention to them exactly!!), I have around 800 items in about 30 notepads.
Is there a way to find double entries in notepads ?

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Sep 12, 2017

Is there a way to find double entries in notepads ?

Sorry, not at the moment.

@otax38

This comment has been minimized.

Copy link
Author

otax38 commented Sep 29, 2017

Hi Martin,

I am back with new info.
I imagine this is linked with previous problem.

I created a new category.
I put 5 items in it.
Then I try to delete the last one in the list (alphabetic order)
But the last is not deleted, it is the previous one in the list that is deleted.
Then I repeat the operation, and again, the previous one is deleted.
After 4 delete operations, only the one that I wanted to delete remains.
Finally that item is deleted correctly because it is the last one in the category.

Can you reproduce that ?

Best regards.

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Oct 2, 2017

Hi, I tried steps as provided by you, and for me it works properly - the last entry is properly deleted. Perhaps this bug can only be reproduced for some particular entries only? Can you please list the entries here, or share a screenshot from your phone? Also, which version of aedict are you using?

@otax38

This comment has been minimized.

Copy link
Author

otax38 commented Oct 2, 2017

Hi Martin,

Thanks for your trial.
Here is a snap :
https://photos.app.goo.gl/37J0BTq3oJtgidv52

I was using previous version of 3.44.
Under 3.44 result is the same

Regards.

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Oct 3, 2017

Thanks! To reproduce, the following entries must be present in a category:

  1. 清潔 せいけつ
  2. 整理 せꜜいり
  3. 清掃 せいそう
  4. 整頓 せいとん
  5. 躾 しつけ

Let me try those out for myself.

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Oct 3, 2017

Actually I have failed to reproduce the issue - when I tried to delete the last one shitsuke (by long-touching it, making sure that only one entry is selected and then I pressed "Delete"), it got properly deleted:

device-2017-10-03-121335

Aha! But let me try to change the "Sort" setting to "By first common reading romanized in Kunrei Shiki".

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Oct 3, 2017

Reproduced! It is important to change the "Sort" setting from "As they were added" to "By first common reading romanized in Kunrei Shiki", then the bug is easily reproducible on nearly any notepad.

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Oct 3, 2017

Fixed in Aedict 3.45

@mvysny mvysny closed this Oct 3, 2017

@mvysny mvysny changed the title Unable to erase an item in a notepad Notepad deletes random item on delete when sorted by reading Oct 3, 2017

@otax38

This comment has been minimized.

Copy link
Author

otax38 commented Oct 3, 2017

Hi Martin,

You got it !

Thanks a lot.
With best regards,
Jean-Pierre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.