Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter should be optionally disabled when not visible in the main screen #811

Closed
mvysny opened this issue Nov 27, 2017 · 6 comments
Closed

Filter should be optionally disabled when not visible in the main screen #811

mvysny opened this issue Nov 27, 2017 · 6 comments
Assignees
Labels

Comments

@mvysny
Copy link
Owner

@mvysny mvysny commented Nov 27, 2017

It is confusing when a filter is applied to a search even though the filter configuration is not visible on screen: the user may receive less results than expected, for no apparent reason. See https://groups.google.com/forum/#!topic/aedict-users/DGqndqydoto for more information.

@mvysny mvysny self-assigned this Nov 27, 2017
@mvysny mvysny added the bug label Nov 27, 2017
@mvysny
Copy link
Owner Author

@mvysny mvysny commented Nov 27, 2017

The current filter configuration should be displayed in the "query" part of the screen (right above the results); but I guess it's not immediately obvious what that means.

I'm thinking to not to apply any filtering when the filter bar is hidden. What do you guys think?

@jimmubreen
Copy link

@jimmubreen jimmubreen commented Nov 27, 2017

Absolutely! Or alternatively when returning results (or saying there are no results) include an alert that there are active filters.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented Nov 29, 2017

Currently there is a small info box that lists all enabled filters. For example:
screenshot_20171129-151318
(Please note the [common only] text). But perhaps I should also include something like "with filters enabled: [common only]" and perhaps include the filter icon? Or would you still prefer filters to be disabled when they're invisible?

@jimmubreen
Copy link

@jimmubreen jimmubreen commented Jan 22, 2018

@mvysny
Copy link
Owner Author

@mvysny mvysny commented Jan 25, 2018

I like the idea of having the stickiness configurable, I'll implement it that way. I'll however keep the default value of true so that the current functionality is preserved.

@mvysny
Copy link
Owner Author

@mvysny mvysny commented Jan 25, 2018

Fixed in Aedict 3.48. Added configuration option Settings / GUI Tuning / Search / Sticky Search Filter

@mvysny mvysny closed this Jan 25, 2018
@mvysny mvysny changed the title Filter should be disabled when not visible in the main screen Filter should be optionally disabled when not visible in the main screen Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants