Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR][Aedict 3] Support for exporting sample words for kanji entries #825

Closed
RemiNV opened this issue Mar 22, 2018 · 4 comments
Closed

[FR][Aedict 3] Support for exporting sample words for kanji entries #825

RemiNV opened this issue Mar 22, 2018 · 4 comments
Assignees

Comments

@RemiNV
Copy link

@RemiNV RemiNV commented Mar 22, 2018

Similarly to the %examples% item in custom exports, I would really appreciate a %words% item that would output 2 or 3 words examples; contents would be identical to the first 2 or 3 entries in the "Words" tab when opening a kanji in Aedict3 (with "Any reading of X" in the dropdown).

Rationale: examples are not very useful when exporting single kanjis (especially for flashcards), since the kanji may be used in an uncommon word or even a name, and it's hard to visually locate the word in the sentence quickly. Word examples are very important when learning kanji through flashcards, though.

I realize that you have little bandwidth for FRs right now, but I would really appreciate this addition - thanks for all the work so far !

@mvysny mvysny self-assigned this Mar 22, 2018
@mvysny
Copy link
Owner

@mvysny mvysny commented Mar 22, 2018

Thanks, that's a great idea! So for example for the kanji the %examples% would be replaced by "本; 本当に; 日本; 本当, 本當" ?

@RemiNV
Copy link
Author

@RemiNV RemiNV commented Mar 22, 2018

Yes, with the associated readings (hiragana) and meanings of each word, that would be great !
Having a separate %words% tag to keep current behavior would be nice, but considering that sentence examples are not so useful for kanji entries, replacing %examples% would work well too.

Thanks !

@mvysny
Copy link
Owner

@mvysny mvysny commented Mar 26, 2018

Will do! Yup, let's leave %examples% as it is. I will introduce a new export tag %words% as you suggested.

@mvysny
Copy link
Owner

@mvysny mvysny commented Mar 26, 2018

Implemented in 3.49

@mvysny mvysny closed this Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants