Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aedict exported entries oversized #831

Closed
dezorianguy opened this Issue Apr 10, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@dezorianguy
Copy link

dezorianguy commented Apr 10, 2018

.ich
good day sir,
thank you for having enlarged the letters within the quiz in aedict. I have 2 improvement request.

  1. could you leave the Kanji with the current size, while reducing the letter size for the hiragana that are being display at the right of the Kanji (when pushing the show answer button, they are display next to the Kanji). the hiragana are often plenty in numbers and shouldn't be taking that much space. hiragana can be reduced by 40 percent size at least.

  2. when exporting notepads to anki Droid the displayed kanji and hiragana are extremely big compared to the regular anki Droid cards you create manually.
    Can you make that the Kanji size within the aedict quiz stays like it is, but reducing the size by 50 percent when exporting to anki Droid?

thanks

@derpda

This comment has been minimized.

Copy link

derpda commented Apr 14, 2018

The second issue seems more like an issue with Anki card types.
It seems that Aedict is using it's own card type. Might there be some way to use an existing Anki card type? That would also improve direct export to Anki of single words.

@mvysny mvysny self-assigned this Apr 18, 2018

@mvysny mvysny added the bug label Apr 18, 2018

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Apr 18, 2018

Good ideas!

  1. Sure, I'll look into this.
  2. Yup, Aedict defines its own card model. I can reduce the size in the card model; however as a quick workaround you can edit the card models yourself in AnkiDroid, and just decrease the font size from 48px to, say, 36px. Perhaps this way you can find the best size and then let me know which one works the best.

It seems that Aedict is using it's own card type. Might there be some way to use an existing Anki card type? That would also improve direct export to Anki of single words.

I think it is recommended that every app that export cards to AnkiDroid creates a card model specifically tailored towards its needs. Aedict has no way knowing which card types there are currently present in AnkiDroid, also Aedict has no way of knowing which card type would be best for displaying japanese word entries.

@derpda

This comment has been minimized.

Copy link

derpda commented Apr 18, 2018

The used name seems to be 'sk.baka.aedict3v6'. When I modify this type and then create a new card in AnkiDroid, Aedict will recreate a type with the same name when adding another word.

If possible, allowing users to modify the AnkiDroid card type that Aedict uses within Aedict (maybe in Expert Settings) might be helpful! =)

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Apr 18, 2018

Hmm that is very weird. Aedict contains the following code (as suggested by Tim of AnkiDroid):

        // Look for our model, add a new one if it doesn't exist
        Long mid = findModelIdByName(api, AnkiDroidConfig.MODEL_NAME, AnkiDroidConfig.FIELDS.length);
        if (mid == null) {
            mid = api.addNewCustomModel(AnkiDroidConfig.MODEL_NAME, AnkiDroidConfig.FIELDS,
                    AnkiDroidConfig.CARD_NAMES, AnkiDroidConfig.QFMT, AnkiDroidConfig.AFMT,
                    AnkiDroidConfig.CSS, did, null);
        }

(the MODEL_NAME is sk.baka.aedict3v7 so there's actually a newer model).

The code therefore checks whether there is such model - if there is, it should leave it as-is.

If possible, allowing users to modify the AnkiDroid card type that Aedict uses within Aedict (maybe in Expert Settings) might be helpful! =)

I belive that's the job of AnkiDroid. Aedict handles its part by exporting all metadata ;)

@derpda

This comment has been minimized.

Copy link

derpda commented Apr 18, 2018

I belive that's the job of AnkiDroid. Aedict handles its part by exporting all metadata ;)

Makes sense =D
I'll try and fiddle around a little more with the note type and Anki export. Maybe I just did something wrong.

One possible issue that I'm seeing however is that the Anki (Windows/PC version) addon 'Japanese Support' expects the word 'Japanese' to be in (or was it at the beginning?) of the note type name. But actually, japanese support should not really be needed as Aedict provides readings and example sentences...

As always, thanks for the quick replies!

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Apr 25, 2018

I have decreased the font size in the AnkiDroid model, please check out the attached screenshot and let me know if this is OK.
device-2018-04-25-140634
In order to apply the formatting, newly exported entries will create their own model sk.baka.aedict3v8. This may appear as if the formatting has been reset, but in fact a new model has been created. You can edit the model and it should stay that way.

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Apr 25, 2018

I have decreased the reading text size from 17sp to 15sp, let me know if this is OK. See attached screenshot for details:
device-2018-04-25-141740

@mvysny mvysny closed this Apr 25, 2018

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Apr 25, 2018

Fixed in Aedict 3.49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.