Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exact search] Example search has no results #863

Closed
rbleuse opened this issue Feb 20, 2019 · 10 comments
Closed

[Exact search] Example search has no results #863

rbleuse opened this issue Feb 20, 2019 · 10 comments
Assignees
Labels

Comments

@rbleuse
Copy link

@rbleuse rbleuse commented Feb 20, 2019

Hello,

If I'm looking for examples that contains ごめん, I get no results.
But If I search ごめん, get the first entry (御免) and go to examples tab, there are plenty results

@mvysny
Copy link
Owner

@mvysny mvysny commented Feb 20, 2019

Hi, thanks for letting me know! This works correctly for me - please make sure that you have at least "Starts With" selected when you do the search.

@rbleuse
Copy link
Author

@rbleuse rbleuse commented Feb 20, 2019

Yes, both example searches give none results
french dictionary, 3.50.10

screenshot_20190220-182431

@mvysny
Copy link
Owner

@mvysny mvysny commented Feb 20, 2019

Yes, that's because there is no exact sentence reading just "ごめん". You need to at least select the 本.. radio button, to find sentences that Start With ごめん.

@rbleuse
Copy link
Author

@rbleuse rbleuse commented Feb 20, 2019

Ok Indeed that's working.
But I don't understand, why are there results if i'm searching 食べる with the same settings and none with ごめん ?
There are no exact sentences with just 食べる

@mvysny
Copy link
Owner

@mvysny mvysny commented Feb 20, 2019

That's a good question. Let me investigate.

@mvysny mvysny reopened this Feb 20, 2019
@mvysny mvysny removed the wontfix label Feb 20, 2019
@rbleuse
Copy link
Author

@rbleuse rbleuse commented Feb 21, 2019

I don't know if that's linked to this exact search problem, but when I search 吸う (すう, to smoke), I get some extra results :
screenshot_20190221-072335

@rbleuse rbleuse changed the title Example search has no results [Exact search] Example search has no results Feb 21, 2019
@mvysny
Copy link
Owner

@mvysny mvysny commented Feb 21, 2019

@mvysny
Copy link
Owner

@mvysny mvysny commented Feb 21, 2019

@rbleuse
Copy link
Author

@rbleuse rbleuse commented Feb 21, 2019

Sure !

@mvysny
Copy link
Owner

@mvysny mvysny commented Mar 1, 2019

The "gomen" part of the bug didn't match since Tatoeba sentence doesn't contain reading for 間違 (gomen) - instead gomen was always present as "間違". Also, previously the whole sentence would have to match the input query exactly, but that doesn't make sense: with Exact I'm searching for exact words, not an exact sentence after all.
Fixed in Aedict 3.50.11 + new dictionary data files. The new data files will be released shortly, please make sure to update your dictionaries. I'll also release new Aedict shortly.

@mvysny mvysny closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants