Permalink
Commits on Nov 13, 2014
  1. Merge pull request #316 from troessner/revamp-README

    mvz committed Nov 13, 2014
    Revamp README.
  2. Revamp README.

    troessner committed Nov 11, 2014
Commits on Nov 9, 2014
  1. Bump version to 1.4.0.

    troessner committed Nov 9, 2014
Commits on Nov 8, 2014
  1. Merge pull request #310 from troessner/refactor-nested-iterators

    Timo Rößner committed Nov 8, 2014
    Simplify NestedIterators detector
  2. Merge pull request #311 from troessner/generate-the-right-wiki-links

    mvz committed Nov 8, 2014
    Generate the right wiki links.
  3. Simplify NestedIterators detector

    mvz committed Nov 5, 2014
  4. Merge pull request #309 from troessner/refactor-control-parameter

    Timo Rößner committed Nov 8, 2014
    Improve and refactor ControlParameter
Commits on Nov 7, 2014
  1. Improve and refactor ControlParameter

    mvz committed Nov 5, 2014
    - Make detector concentrate on use of parameter as a value. Using the
      result of a method call involving the parameter is considered
      legitimate use. Comparing to a value is not.
    - Handle edge cases like use of if inside a condition
    - Re-format specs
    - Refactor smell detector
Commits on Nov 6, 2014
  1. Merge pull request #308 from troessner/refactor-nilcheck

    Timo Rößner committed Nov 6, 2014
    Improve and refactor NilCheck
  2. Improve and refactor NilCheck

    mvz committed Nov 5, 2014
    - Detect NilCheck for `when` with multiple conditions
    - Decouple NilCheck smell detector code from Sexp
    - DRY up NilCheck node finder code
Commits on Nov 5, 2014
  1. Merge pull request #305 from troessner/add-ultra-verbose-warning-form…

    mvz committed Nov 5, 2014
    …atter
    
    Add ultra verbose warning formatter.
Commits on Nov 3, 2014
Commits on Nov 1, 2014
  1. Merge pull request #297 from troessner/issue-add-rubocop-config

    Timo Rößner committed Nov 1, 2014
    Start using RuboCop
  2. Introduce RuboCop and fix offenses

    mvz committed with troessner Oct 26, 2014
    * Add RuboCop configuration
    * Fix offenses
    
    This does not fix all offenses. These can be fixed as and when the
    relevant code is touched. The following offenses are left:
    
    - Metrics/ClassLength
    - Metrics/LineLength
    - Metrics/MethodLength
    - Metrics/ParameterLists
    - Style/Documentation
Commits on Oct 27, 2014
  1. Merge pull request #301 from troessner/exclude-non-source-directories…

    mvz committed Oct 27, 2014
    …-from-rdoc
    
    Exclude non-source directories from rdoc.
Commits on Oct 17, 2014
  1. Merge pull request #300 from aakritigupta/re-factor_to_reek_less

    Timo Rößner committed Oct 17, 2014
    Re factor to reek less
Commits on Oct 16, 2014
  1. Break down report generation into strategies and report classes

    aakritigupta committed Oct 14, 2014
    - 3 different strategies
    - text, yaml html report formats
  2. Re-factor Report class and add specs

    aakritigupta committed Oct 5, 2014
    - handle output with or without any smells
    - Use has_smells? instead of checking for number of smells repeatedly
    - Use options instead of multiple params
    - Capture output stream in a separate method in specs
    - Add attr_reader for smells and initialise a class attribute for smells
Commits on Sep 28, 2014
  1. Merge pull request #276 from troessner/run-single-detector

    Timo Rößner committed Sep 28, 2014
    Run single detector
  2. Add support for detecting specific smells

    mvz committed May 25, 2013
    This adds the command-line option --smell to specify a smell to detect.
    This option can be applied multiple times.
    
    Some refactoring was needed to be able to pass the smells to detect down
    to where the actual detection takes place.
Commits on Sep 26, 2014
  1. Merge pull request #299 from troessner/issue-clean-up-debugger-gems

    Timo Rößner committed Sep 26, 2014
    Clean up debugger gems
  2. Remove debugger gems from the bundle

    mvz committed Sep 26, 2014
    Removes debugger, byebug and pry_debug from the bundle, and fixes
    instructions in README.md accordingly.
  3. Merge pull request #298 from troessner/issue-require-ruby-1-9-2

    Timo Rößner committed Sep 26, 2014
    Require Ruby 1.9.2 or up
  4. Require Ruby 1.9.2 or up

    mvz committed Sep 18, 2014
Commits on Sep 25, 2014
  1. Merge pull request #293 from troessner/clean-up-rake

    Timo Rößner committed Sep 25, 2014
    Clean up cruft from rake tasks
  2. Merge pull request #296 from troessner/fix-test-quality-task

    Timo Rößner committed Sep 25, 2014
    Make rake test:quality work
  3. Make rake test:quality work

    mvz committed Sep 25, 2014
    The pattern option does not seem to work if it does not start with
    'spec'.
Commits on Sep 18, 2014
  1. Clean up rake tasks

    mvz committed Sep 10, 2014
    * Remove metric_fu tasks
      - metric_fu now has its own runner
      - metric_fu is not part of the bundle, so these tasks were not
        available when run with `bundle exec`
      - loading these tasks takes an insanely long time
    * Delay loading yaml dependency until needed
    * Delay requiring Reek sniffer until needed
    * Remove dependency declarations for obsolete tasks
    * Remove unused Rakefile constants
    * Remove needless dependencies
    * Do not manipulate the load path: The 'lib' directory is already added
      to the load path by 'bundler/gem_tasks'.
    * Remove needless square brackets
    * Expect config/ to exist: its contents is in git, and it should not be
      removed by `rake clobber`.
Commits on Sep 10, 2014
  1. Merge pull request #292 from troessner/fix-rspec-patterns

    Timo Rößner committed Sep 10, 2014
    Stop using FileList to specify RSpec patterns
  2. Stop using FileList to specify RSpec patterns

    mvz committed Sep 10, 2014
    This was never meant to work.
Commits on Aug 30, 2014
  1. Merge pull request #289 from gilles-leblanc/issue-287

    troessner committed Aug 30, 2014
    Color total warning count depending on number of warnings
Commits on Aug 29, 2014
  1. Color total warning count depending on number of warnings

    gilles-leblanc committed Aug 29, 2014
    If there are no warnings, the output will be green, otherwise it will be
    red.
    
    Fixes #287