Moandji Ezana mwanji

mwanji commented on issue webjars/webjars#971
@mwanji

You could improve the POM to exclude the folders and files you don't need. An 85MB webjar doesn't sound useful to anybody.

mwanji commented on pull request mwanji/toml4j#10
@mwanji

This is now on the wip branch. It will be released whenever there's an upstream release, unless you need an official release before then. Otherwise…

mwanji closed issue mwanji/toml4j#6
@mwanji
Support Inline-Tables
mwanji commented on issue mwanji/toml4j#6
@mwanji

This was released in v0.4.0

mwanji pushed to wip at mwanji/toml4j
@mwanji
mwanji pushed to wip at mwanji/toml4j
@mwanji
mwanji commented on issue toml-lang/toml#320
@mwanji

In case 1, a is defined twice. It doesn't matter if the types are "compatible" or not (which I don't think they are). In case 2, a and a.c are defi…

mwanji commented on pull request mwanji/toml4j#10
@mwanji

On this line I use the lower-level get(String), which returns null if the key is missing. And there's a test to verify behaviour. Is this incorrect…

mwanji commented on pull request mwanji/toml4j#10
@mwanji

I've merged your changes into the default_values branch, added defaults for arrays and updated the readme and change log. Let me know if it looks O…

mwanji created branch default_values at mwanji/toml4j
mwanji commented on pull request mwanji/toml4j#10
@mwanji

Also, is there a reason for not having a default method for getList?

mwanji commented on pull request mwanji/toml4j#10
@mwanji

I thinks, method-level defaults should override constructor-level defaults, this is more conventional. I just checked, and in java.util.Propertie…

@mwanji
@mwanji
  • @mwanji 3d9c853
    Updated after switching hosting to github
@mwanji
mwanji commented on pull request mwanji/toml4j#10
@mwanji

I just realised I can merge it into wip myself (obviously!), so never mind that.

mwanji commented on pull request mwanji/toml4j#10
@mwanji

Thanks a lot for this, I'd been thinking about adding something similar. Have you tried to use the existing defaults system? Was it not sufficient/…

mwanji pushed to master at mwanji/toml4j
@mwanji
  • @mwanji 5a608ca
    Clarified that PRs should be against wip branch