Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customizable action sheets to the photo browser #75

Closed
wants to merge 2 commits into from
Closed

Added customizable action sheets to the photo browser #75

wants to merge 2 commits into from

Conversation

hoan
Copy link

@hoan hoan commented Oct 3, 2012

It adds this optional method to the delegate

  • (void) photoBrowser:(MWPhotoBrowser *)photoBrowser actionIndex:(NSUInteger)index;

Set the actions this way:

browser.displayActionButton = YES;
browser.actionButtons = [NSArray arrayWithObjects:@"Save", "Copy", "Flag", nil];

Thanks for the great library. This gives us the ability to customize the action sheets and implement whatever kind of things we want. I've updated the readme as well. Only bad thing is that the default "Copy" etc are not ever called.

@koenoe
Copy link

koenoe commented Oct 12, 2012

Unfortunately it doesn't work in iOS6. App crashes right away. I need this function, so maybe I'll do an attempt to implement it.

@hoan
Copy link
Author

hoan commented Oct 13, 2012

@koenoe I've got this to work on iOS6 where I'm testing my new app. Show me your code and maybe I can help

@koenoe
Copy link

koenoe commented Dec 6, 2012

Sorry for the late reply, but I already managed to fix it. You can see my code here:
https://github.com/koenoe/kitties-ios/blob/master/kitties/MWPhotoBrowser/Classes/MWPhotoBrowser.m

@jonasman
Copy link

This feature is great. specially to add options like "share to FB". when is it gonna be merged to master?
I didnt want to use forks :S

@bushbert77
Copy link

Yeah this was the first thing I asked myself was I able to add custom actions. So fantastic work which I'm sure will be so helpful for so many. Unfortunately for me, it crashes in IOS6. If don't set the actionbuttons array it works with a blank action menu. Just wondered if anyone had come across this issue to save me a little time. I just updated my MWPhotoBrowser header and module files as suggested and I get a bad access and crash.Thanks!

@hoan
Copy link
Author

hoan commented Jan 22, 2013

Yes I've made some more changes so it works better like passing back the
photo index. Will update my branch when I have time. Have been running it
on ios6 with no problems.

On Tue, Jan 22, 2013 at 7:02 AM, Jonathan Bushby
notifications@github.comwrote:

Yeah this was the first thing I asked myself was I able to add custom
actions. So fantastic work which I'm sure will be so helpful for so many.
Unfortunately for me, it crashes in IOS6. If don't set the actionbuttons
array it works with a blank action menu. Just wondered if anyone had come
across this issue to save me a little time. I just updated my
MWPhotoBrowser header and module files as suggested and I get a bad access
and crash.Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/75#issuecomment-12548146.

@mwaterfall mwaterfall closed this in ebf3a06 Oct 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants