Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Nov 19, 2012
  1. @beneater

    Don't initialize matrix-input unless matrix-input module is explicitl…

    beneater authored
    …y loaded
    
    Auditors: stephanie
    
    Test plan: In devappserver, load a non-matrix exercise and note the JS error,
    apply this fix, note the absense of the JS error, and that matrix input works
    for matrix exercises.
  2. @beneater

    Add video hint experiment for factoring_polynomials_1

    beneater authored
    Summary: Add video hints, solution only, and steps only to the existing exercise with detailed hints
    
    Test Plan: Tested each locally
    
    Reviewers: stephanie
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D929
  3. @beneater

    Remove empty examples from unit_circle

    beneater authored
    I guess the old answer-types.js ignored this case
    
    Test plan: Previously hovering over "acceptable formats" in unit_circle showed
    a bullet with nothing next to it. After this fix, the "acceptable formats"
    doesn't appear.
    
    Auditors: emily
Commits on Nov 18, 2012
  1. Add exercises: Finding the determinant of a matrix, finding the inver…

    Stephanie H. Chang authored
    …se of a matrix
    
    Test Plan: Tested locally
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D891
Commits on Nov 16, 2012
  1. @beneater
  2. @beneater

    Merge pull request #33803 from xymostech/fix-fallback

    beneater authored
    Fix fallbacks in answer types. fix #33883
  3. @beneater

    Restore acceptable format defaulting for multiple answer type

    beneater authored
    In the case where a "multiple" answer-type doesn't have any examples defined
    and contains only one input element, inherit the acceptable formats from that
    single input element.
    
    Test Plan: Verify acceptable answers show up for
        http://localhost:8000/exercises/one_step_equations.html
    
    Auditors: emily
  4. @beneater

    Fix #33834 regression introduced by new answer-types.js

    beneater authored
    The multiple answer type wasn't properly tracking data-forms for each element
    
    Test plan: Test http://localhost:8000/exercises/multiplying_mixed_numbers_1.html?debug&problem=0&seed=7 to verify that 23/3 is not accepted after this fix.
    
    Auditors: emily
Commits on Nov 15, 2012
  1. @xymostech

    Fix fallbacks in answer types

    xymostech authored
    Because `undefined + ""` produces the string `"undefined"`, fallbacks
    did not accurately show that they were not available. This causes
    some/all of the problems to inaccurately never report that an answer was
    not entered. This should fix that.
  2. @xymostech

    Remove the solution fallback

    xymostech authored
  3. @beneater

    Merge pull request #33787 from xymostech/fix-33675

    beneater authored
    Fix width problems in reading_tables_2
  4. @xymostech

    Lint

    xymostech authored
  5. @xymostech
Commits on Nov 14, 2012
  1. @tzjames

    Copied over review D909. Added a comment.

    tzjames authored
    Summary: I didn't commit --amend, thought it would be easier just with a new branch.
    
    Test Plan: Same as in that review
    
    Reviewers: kamens
    
    Reviewed By: kamens
    
    Differential Revision: http://phabricator.khanacademy.org/D921
  2. @beneater

    Sync exercises/khan-exercise.html

    beneater authored
    Auditors: csilvers
  3. @csilvers

    Convert .gif's to .png's in khan-exercises.

    csilvers authored
    Summary:
    The purpose of this conversion is to have (basically) only file format
    we use for images, to make our tools more effective.  For instance, we
    have a tool for compressing png's, but not gif's.
    
    We've already changed face-smiley to be a .png in stable, so this
    mirrors that.
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D920
  4. @beneater

    Fix a bunch of things

    beneater authored
    Reviewers: emily
    
    Reviewed By: emily
    
    Differential Revision: http://phabricator.khanacademy.org/D904
  5. @spicyj

    Forward slashes, not back

    spicyj authored
    Auditors: eater
Commits on Nov 13, 2012
  1. @beneater

    Fix #33076 remove extraneous hint

    beneater authored
    Summary: There's no reason for one-root to inherit from original
    
    Test Plan: Tested locally
    
    Reviewers: stephanie
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D897
Commits on Nov 12, 2012
  1. @spicyj

    Change capitalization of jQuery

    spicyj authored
    Auditors: csilvers
  2. @spicyj

    Fix typo

    spicyj authored
    Auditors: csilvers
Commits on Nov 9, 2012
  1. @beneater

    Add some of Stephanie's new colors

    beneater authored
    Test Plan: Tested locally
    
    Reviewers: stephanie
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D908
  2. @beneater

    `*` -> `\times`

    beneater authored
    Summary: We don't use or introduce '*' as meaning multiplication anywhere
    
    Test Plan: Local
    
    Reviewers: stephanie
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D907
Commits on Nov 8, 2012
  1. @beneater

    Sync exercises/khan-exercise.html

    beneater authored
    Test plan: cross fingers
    
    Auditors: alpert
Commits on Nov 6, 2012
  1. @tzjames

    added a check to see if xhr exists, that will remove the out-of-date …

    tzjames authored
    …warning on the following page load
    
    Summary: This change will not solve people seeing the out-of-date warning message the first time, it may however fix the issue where people refresh the page and still see the out of date warning message.  Specifically if the xhr becomes undefined before this change an error was thrown and the cache never got cleared.  Deleting the fkey cookie was one way in which this seems to have happened.
    
    Test Plan: Went to an exercise in chrome or ff.  Deleted fkey cookie. Answered a question and an error was thrown saying xhr was undefined. Because the error was thrown the Khan exercise cache did not get cleared and the red message bar did not show up.  Then reloaded the page, the wrong problem number is reloaded from the cache, did an problem, and got another page is out of date warning - this time the red warning gets called and the cache gets cleared.  Subsequent reloads and all is fine.
    
    Reviewers: kamens
    
    Reviewed By: kamens
    
    Differential Revision: http://phabricator.khanacademy.org/D899
Commits on Nov 2, 2012
  1. @beneater

    Don't ask about ambiguous triangles in law_of_sines

    beneater authored
    Test Plan: Test http://localhost:8000/exercises/law_of_sines.html?seed=16&problem=find-angle&debug before and after
    
    Auditors: stephanie
Commits on Nov 1, 2012
  1. @beneater

    Merge pull request #32925 from xcvd/formatting_fixes

    beneater authored
    Unclosed span tag
  2. @beneater

    Round correct answer in law_of_cosines to the nearest degree

    beneater authored
    Test plan: tested locally with http://localhost:8000/exercises/law_of_cosines.html?seed=75&problem=sss-find-angle&debug
    
    Auditors: stephanie
  3. @beneater

    Fix display issue in law of {sines|cosines}

    beneater authored
    Test Plan: Tested in devappserver. Verified triangle was drawn incorrectly,
    made change, verified it was displayed correctly (for the same problem since
    I hadn't answered it yet)
    
    Auditors: stephanie
  4. @xcvd

    Unclosed span tag

    xcvd authored
    Text is green where only 'y-coordinate' should be.
Commits on Oct 29, 2012
  1. @beneater

    Merge pull request #32747 from karlanderson/7a27b0774be5a7b82d865863e…

    beneater authored
    …49209c9102532b5
    
    Fix tense in hint to match problem statement
Commits on Oct 26, 2012
  1. @beneater

    Merge pull request #32633 from mauk81/patch-2

    beneater authored
    Linear equation word problems - fix typo (fix #32619)
  2. fix typo

    maik authored
  3. Fix spacing for answer inputs in scalar matrix multiplication

    Stephanie H. Chang authored
    Test Plan: Tested locally
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D872
  4. @beneater

    A problem type in multistep_equations always computes the wrong answer

    beneater authored
    Test Plan: Looked at http://localhost:8000/exercises/multistep_equations_with_distribution.html?seed=114&problem=prob1&debug before and after
    
    Auditors: stephanie
Something went wrong with that request. Please try again.