Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rendering of empty dataframes #184

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Fix the rendering of empty dataframes #184

merged 3 commits into from
Jun 11, 2023

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jun 11, 2023

In this PR, we make sure that all the possible variations of empty dataframes (empty, no rows, no columns etc) are rendered correctly - previously on some of these empty dataframes we were seeing a message "loading" forever.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2023

Codecov Report

Merging #184 (20eaf7a) into main (dbc66c1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   97.29%   97.30%   +0.01%     
==========================================
  Files          24       25       +1     
  Lines         849      853       +4     
==========================================
+ Hits          826      830       +4     
  Misses         23       23              
Impacted Files Coverage Δ
itables/sample_dfs.py 100.00% <ø> (ø)
itables/javascript.py 94.11% <100.00%> (+0.02%) ⬆️
itables/shiny.py 100.00% <100.00%> (ø)
itables/version.py 100.00% <100.00%> (ø)
tests/sample_python_apps/itables_in_a_shiny_app.py 100.00% <100.00%> (ø)
...le_python_apps/itables_in_a_shiny_app_with_tabs.py 100.00% <100.00%> (ø)
tests/test_documentation_notebooks_run.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mwouts mwouts merged commit 375bfc4 into main Jun 11, 2023
@mwouts mwouts deleted the fix_empty_df branch October 1, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants