Micah Wylde mwylde

Organizations

@wesleyan @SiftScience
mwylde deleted branch micah_yaml_schemas at SiftScience/jsonschema2pojo
@mwylde
@mwylde
(For Jacob) Added support for json schemas in yaml
1 commit with 66 additions and 4 deletions
@mwylde
(For Jacob) Added support for json schemas in yaml
1 commit with 66 additions and 4 deletions
@mwylde
  • @mwylde 933da30
    Updated travis configuration to test more rubies
@mwylde
  • @mwylde 50fec48
    Work on updating sift-ruby for device fingerprinting
mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

This broadly looks good to me, although we need to think a bit more about how errors should work.

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

What's this?

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

This isn't very friendly — raising a generic RuntimeException limits clients' ability to handle errors gracefully. There's also no easy way for the…

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

Should we validate that Sift.account_id has been filled in?

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

Should this have an implementation (I realize it's not used now)?

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

What's this?

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

nit: extra line

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

Should this (and the session id) be specifiable on the command line? More broadly, do we expect users to run this program or just use it as an exam…

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

these should probably all be to stderr — i.e., $stderr.puts

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

Should probably have an error code — exit 1

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

You use API_ID here and ACCOUNT_ID in line 11

mwylde commented on pull request SiftScience/sift-ruby#30
@mwylde

Date?

@mwylde