{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":495529772,"defaultBranch":"main","name":"WebKit","ownerLogin":"mwyrzykowski","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-05-23T18:33:22.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/105083895?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1719870723.0","currentOid":""},"activityList":{"items":[{"before":"bd927af0c263e8476da4e289b7aff477e7a22aa9","after":"5164703263d13baeb378f4d041fd8209569ae176","ref":"refs/heads/eng/String-shows-incorrectly-in-open-model-prompt","pushedAt":"2024-07-02T18:12:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"webkit-commit-queue","name":"Commit Queue","path":"/webkit-commit-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77073439?s=80&v=4"},"commit":{"message":"String shows incorrectly in open model prompt\nhttps://bugs.webkit.org/show_bug.cgi?id=276094\n<radar://130919961>\n\nReviewed by Jer Noble.\n\n278998@main should have used WEB_UI_NSSTRING_KEY instead of WEB_UI_NSSTRING\notherwise the string in Localizable.strings could get inintentionally overwritten\nby running update-webkit-localizable-strings as seen in 280128@main.\n\n* Source/WebCore/en.lproj/Localizable.strings:\n* Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:\n\nCanonical link: https://commits.webkit.org/280583@main","shortMessageHtmlLink":"String shows incorrectly in open model prompt"}},{"before":"aab71f154af7cabe630132e1f55b31a8c111b773","after":"a53489362accb8a5fe3bf4073252cdfbb79869b0","ref":"refs/heads/eng/WebGPU-water-demo-does-not-show-water-effect","pushedAt":"2024-07-02T15:51:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"webkit-commit-queue","name":"Commit Queue","path":"/webkit-commit-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77073439?s=80&v=4"},"commit":{"message":"[WebGPU] water demo does not show water effect\nhttps://bugs.webkit.org/show_bug.cgi?id=275930\n<radar://130566049>\n\nReviewed by Tadeu Zagallo.\n\nWorkaround apparent driver bug where clearDepth was not\nignored when loadAction was not MTLLoadActionClear.\n\nNo regresion to api,validation,render_pass CTS test.\n\n* Source/WebGPU/WebGPU/CommandEncoder.mm:\n(WebGPU::CommandEncoder::beginRenderPass):\n\nCanonical link: https://commits.webkit.org/280581@main","shortMessageHtmlLink":"[WebGPU] water demo does not show water effect"}},{"before":null,"after":"bd927af0c263e8476da4e289b7aff477e7a22aa9","ref":"refs/heads/eng/String-shows-incorrectly-in-open-model-prompt","pushedAt":"2024-07-01T21:52:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"String shows incorrectly in open model prompt\nhttps://bugs.webkit.org/show_bug.cgi?id=276094\n<radar://130919961>\n\nReviewed by NOBODY (OOPS!).\n\n278998@main should have used WEB_UI_NSSTRING_KEY instead of WEB_UI_NSSTRING\notherwise the string in Localizable.strings could get inintentionally overwritten\nby running update-webkit-localizable-strings as seen in 280128@main.\n\n* Source/WebCore/en.lproj/Localizable.strings:\n* Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:","shortMessageHtmlLink":"String shows incorrectly in open model prompt"}},{"before":"4f47a298c2e3200136c20863650d779f7bf31c8e","after":"3a437945ebe2ebb453219f6a4d24f32a038a223c","ref":"refs/heads/main","pushedAt":"2024-07-01T21:51:55.000Z","pushType":"push","commitsCount":110,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"grid-within-flexbox-indefinite.html now passing\nhttps://bugs.webkit.org/show_bug.cgi?id=276077\nrdar://problem/130903429\n\nReviewed by Sammy Gill.\n\nTest case was passing now when running layout tests.\n\n* LayoutTests/TestExpectations:\n\nCanonical link: https://commits.webkit.org/280552@main","shortMessageHtmlLink":"grid-within-flexbox-indefinite.html now passing"}},{"before":"2e6ca87521324718d852a561c570ca9d9dce0ae4","after":"efa8149ffba6affc87b822e577e1a3a05d95121a","ref":"refs/heads/eng/WebGPU-errorValidatingDynamicOffsets-can-be-bypassed-in-setBindGroup","pushedAt":"2024-06-28T17:05:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"webkit-commit-queue","name":"Commit Queue","path":"/webkit-commit-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77073439?s=80&v=4"},"commit":{"message":"[WebGPU] errorValidatingDynamicOffsets can be bypassed in setBindGroup\nhttps://bugs.webkit.org/show_bug.cgi?id=275691\n<radar://130148080>\n\nReviewed by Tadeu Zagallo.\n\nSwitch add -> set in HashMap call, add was unintentional.\n\n* Source/WebGPU/WebGPU/ComputePassEncoder.mm:\n(WebGPU::ComputePassEncoder::setBindGroup):\n\nCanonical link: https://commits.webkit.org/280458@main","shortMessageHtmlLink":"[WebGPU] errorValidatingDynamicOffsets can be bypassed in setBindGroup"}},{"before":"4411f6a83847978d380d4b56ba1dd6fcd59e9cae","after":"1404a800df889699d23e23b63a1d018aeb3c1f2e","ref":"refs/heads/eng/WebGL-Allocate-PixelBuffer-for-read-back-in-web-process","pushedAt":"2024-06-28T04:52:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"[WebGL] Allocate PixelBuffer for read back in web process\nhttps://bugs.webkit.org/show_bug.cgi?id=275761\n<radar://129677619>\n\nReviewed by NOBODY (OOPS!).\n\nAllocate PixelBuffer in web process and pass through to GPU process\nto avoid memory allocation in the GPU process.\n\n* Source/WebCore/Headers.cmake:\n* Source/WebCore/Sources.txt:\n* Source/WebCore/WebCore.xcodeproj/project.pbxproj:\n* Source/WebCore/bindings/js/SerializedScriptValue.cpp:\n* Source/WebCore/platform/graphics/GraphicsContextGL.h:\n* Source/WebCore/platform/graphics/PixelBuffer.h:\n(WebCore::PixelBuffer::isShareablePixelBuffer const):\n* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:\n(WebCore::GraphicsContextGLANGLE::readPixelsForPaintResults):\n(WebCore::GraphicsContextGLANGLE::updatePixelsForPaintResults):\n(WebCore::GraphicsContextGLANGLE::drawingBufferToPixelBuffer):\n* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:\n* Source/WebKit/GPUProcess/graphics/ImageBufferShareableAllocator.cpp:\n* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:\n* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:\n* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:\n(drawingBufferToPixelBuffer):\n* Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.cpp: Removed.\n* Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.h: Removed.\n* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp:\n* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h:\n* Source/WebKit/Scripts/webkit/messages.py:\n(types_that_must_be_moved):\n* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:\n* Source/WebKit/Sources.txt:\n* Source/WebKit/WebKit.xcodeproj/project.pbxproj:\n* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:\n* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:\n(WebKit::RemoteGraphicsContextGLProxy::drawingBufferToPixelBuffer):","shortMessageHtmlLink":"[WebGL] Allocate PixelBuffer for read back in web process"}},{"before":"ffe70b064140eb49c0ba220540cf500a532b5899","after":"4f47a298c2e3200136c20863650d779f7bf31c8e","ref":"refs/heads/main","pushedAt":"2024-06-28T04:52:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"[WinCairo] Unreviewed test gardening\n\n* LayoutTests/platform/wincairo/TestExpectations:\n\nCanonical link: https://commits.webkit.org/280442@main","shortMessageHtmlLink":"[WinCairo] Unreviewed test gardening"}},{"before":"908d2ad5ec7951720d9bc0f807be516eb9313de1","after":"4411f6a83847978d380d4b56ba1dd6fcd59e9cae","ref":"refs/heads/eng/WebGL-Allocate-PixelBuffer-for-read-back-in-web-process","pushedAt":"2024-06-28T04:01:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"}},{"before":"f3fe7d5be8193ca15e0446e97fd5e0235756a9b3","after":"ffe70b064140eb49c0ba220540cf500a532b5899","ref":"refs/heads/main","pushedAt":"2024-06-28T04:01:37.000Z","pushType":"push","commitsCount":23,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"Fix instance method '-_setAttachmentElementEnabled:' not found, was missing import\nhttps://bugs.webkit.org/show_bug.cgi?id=275981\nrdar://problem/130725061\n\nUnreviewed build fix.\n\nProbably caused by unrelated change that affected unified builds.\n\n* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:\n\nCanonical link: https://commits.webkit.org/280441@main","shortMessageHtmlLink":"Fix instance method '-_setAttachmentElementEnabled:' not found, was m…"}},{"before":null,"after":"32c952cb0c5f9674afdd2f256ba078f2faf4cdeb","ref":"refs/heads/eng/WebGPU-chat-webllm-ai-does-not-work-on-iOS-because-chat-webllm-ai-requires-1GB-buffer-size","pushedAt":"2024-06-27T18:09:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"[WebGPU] chat.webllm.ai does not work on iOS because chat.webllm.ai requires 1GB buffer size\nhttps://bugs.webkit.org/show_bug.cgi?id=275958\n<radar://130687763>\n\nReviewed by NOBODY (OOPS!).\n\nAllow websites to create buffers with lengths greater than one-tenth\nof the MTLDevice's max buffer length, but at most support 1GB as the\nweb content process will quickly jetsam after that.\n\n* Source/WebGPU/WebGPU/HardwareCapabilities.mm:\n(WebGPU::maxBufferSize):","shortMessageHtmlLink":"[WebGPU] chat.webllm.ai does not work on iOS because chat.webllm.ai r…"}},{"before":"2fa61017253a233fd17a857fd9f903e58c4d79a0","after":"f3fe7d5be8193ca15e0446e97fd5e0235756a9b3","ref":"refs/heads/main","pushedAt":"2024-06-27T18:09:43.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"[Cocoa] Clean up AVFoundation MIME type code\nhttps://bugs.webkit.org/show_bug.cgi?id=275867\nrdar://128759015\n\nReviewed by Andy Estes.\n\nRemove some unused MIME type code from MediaPlayerPrivateAVFoundation.cpp. Remove\nogg from the MIME types rejected without consulting AVFoundation.\n\n* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:\n(WebCore::MediaPlayerPrivateAVFoundation::isUnsupportedMIMEType): Deleted.\n(WebCore::MediaPlayerPrivateAVFoundation::staticMIMETypeList): Deleted.\n* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:\n* Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:\n(WebCore::AVAssetMIMETypeCache::isUnsupportedContainerType):\n\nCanonical link: https://commits.webkit.org/280418@main","shortMessageHtmlLink":"[Cocoa] Clean up AVFoundation MIME type code"}},{"before":null,"after":"aab71f154af7cabe630132e1f55b31a8c111b773","ref":"refs/heads/eng/WebGPU-water-demo-does-not-show-water-effect","pushedAt":"2024-06-27T00:02:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"[WebGPU] water demo does not show water effect\nhttps://bugs.webkit.org/show_bug.cgi?id=275930\n<radar://130566049>\n\nReviewed by NOBODY (OOPS!).\n\nWorkaround apparent driver bug where clearDepth was not\nignored when loadAction was not MTLLoadActionClear.\n\nNo regresion to api,validation,render_pass CTS test.\n\n* Source/WebGPU/WebGPU/CommandEncoder.mm:\n(WebGPU::CommandEncoder::beginRenderPass):","shortMessageHtmlLink":"[WebGPU] water demo does not show water effect"}},{"before":"eccc1e5ca4435122c8d03f4dbedd7e7671387a0b","after":"2fa61017253a233fd17a857fd9f903e58c4d79a0","ref":"refs/heads/main","pushedAt":"2024-06-27T00:02:04.000Z","pushType":"push","commitsCount":26,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"[Gardening]: REGRESSION(280114@main): [ macOS wk2 ] 2 tests in css-view-transitions are consistent failure\nhttps://bugs.webkit.org/show_bug.cgi?id=275928\nrdar://130628245\n\nUnreviewed test gardening.\n\nAdding test expectation\n\n* LayoutTests/platform/mac-wk2/TestExpectations:\n\nCanonical link: https://commits.webkit.org/280399@main","shortMessageHtmlLink":"[Gardening]: REGRESSION(280114@main): [ macOS wk2 ] 2 tests in css-vi…"}},{"before":"ff08592a9c53c2253188c9dce133b0db31c2ca3d","after":"908d2ad5ec7951720d9bc0f807be516eb9313de1","ref":"refs/heads/eng/WebGL-Allocate-PixelBuffer-for-read-back-in-web-process","pushedAt":"2024-06-26T15:24:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"}},{"before":"22ddcd61c1477e712bd375196ab1193e1f7c8d02","after":"eccc1e5ca4435122c8d03f4dbedd7e7671387a0b","ref":"refs/heads/main","pushedAt":"2024-06-26T15:23:42.000Z","pushType":"push","commitsCount":21,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"Remove local `missing-values-first-keyframe` and `missing-values-last-keyframe` tests in favor of WPT\n\nhttps://bugs.webkit.org/show_bug.cgi?id=275900\n\nReviewed by Antoine Quint.\n\nThese tests exist as 'reftest' on WPT and already in our repo / imported.\nSo this patch deletes our local tests.\n\nBoth exists with same name in 'css/css-animations' on Web Platform Test suite (WPT).\n\n* LayoutTests/animations/missing-values-first-keyframe-expected.png: Removed.\n* LayoutTests/animations/missing-values-first-keyframe.html: Removed.\n* LayoutTests/animations/missing-values-last-keyframe-expected.png: Removed.\n* LayoutTests/animations/missing-values-last-keyframe.html: Removed.\n* LayoutTests/platform/glib/animations/missing-values-first-keyframe-expected.txt: Removed.\n* LayoutTests/platform/glib/animations/missing-values-last-keyframe-expected.txt: Removed.\n* LayoutTests/platform/gtk/animations/missing-values-first-keyframe-expected.png: Removed.\n* LayoutTests/platform/gtk/animations/missing-values-last-keyframe-expected.png: Removed.\n* LayoutTests/platform/ios/animations/missing-values-first-keyframe-expected.txt: Removed.\n* LayoutTests/platform/ios/animations/missing-values-last-keyframe-expected.txt: Removed.\n* LayoutTests/platform/mac/animations/missing-values-first-keyframe-expected.txt: Removed.\n* LayoutTests/platform/mac/animations/missing-values-last-keyframe-expected.png: Removed.\n* LayoutTests/platform/mac/animations/missing-values-last-keyframe-expected.txt: Removed.\n* LayoutTests/platform/wincairo/animations/missing-values-first-keyframe-expected.txt: Removed.\n* LayoutTests/platform/wincairo/animations/missing-values-last-keyframe-expected.txt: Removed.\n\nCanonical link: https://commits.webkit.org/280373@main","shortMessageHtmlLink":"Remove local <code>missing-values-first-keyframe</code> and `missing-values-last…"}},{"before":"7961c445d1ab90f6e37da3e9b83f3d07592710b7","after":"ff08592a9c53c2253188c9dce133b0db31c2ca3d","ref":"refs/heads/eng/WebGL-Allocate-PixelBuffer-for-read-back-in-web-process","pushedAt":"2024-06-25T21:32:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"}},{"before":"e127c6bb3b51fa1c5b2448c44f64d512f3aa7cd0","after":"22ddcd61c1477e712bd375196ab1193e1f7c8d02","ref":"refs/heads/main","pushedAt":"2024-06-25T21:32:23.000Z","pushType":"push","commitsCount":88,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"[Site Isolation] Reduce use of legacyMainFrameProcess\nhttps://bugs.webkit.org/show_bug.cgi?id=275840\nrdar://130480207\n\nReviewed by Charlie Wolfe and Sihui Liu.\n\nIf we are sending a message and have a frameID, use that frameID to get the process\nto send to.\n\n* Source/WebKit/UIProcess/API/C/WKInspector.cpp:\n(WKInspectorShowMainResourceForFrame):\n* Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:\n(-[_WKInspector showMainResourceForFrame:]):\n* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp:\n(webkitPrintOperationPrintPagesForFrame):\n(webkitPrintOperationSendPagesToPrintPortal):\n* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:\n(WebKit::WebPageProxy::contentFilterDidBlockLoadForFrame):\n* Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp:\n(WebKit::WebInspectorUIProxy::showMainResourceForFrame):\n* Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:\n* Source/WebKit/UIProcess/WebFrameProxy.cpp:\n(WebKit::WebFrameProxy::navigateServiceWorkerClient):\n(WebKit::WebFrameProxy::bindAccessibilityFrameWithData):\n(WebKit::WebFrameProxy::loadURL):\n(WebKit::WebFrameProxy::loadData):\n(WebKit::WebFrameProxy::collapseSelection):\n* Source/WebKit/UIProcess/WebPageProxy.cpp:\n(WebKit::WebPageProxy::handleMouseEventReply):\n(WebKit::WebPageProxy::sendMouseEvent):\n(WebKit::WebPageProxy::processNextQueuedMouseEvent):\n(WebKit::WebPageProxy::drawPagesForPrinting):\n(WebKit::WebPageProxy::sendSyncToProcessContainingFrame):\n* Source/WebKit/UIProcess/WebPageProxy.h:\n* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:\n(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):\n(WebKit::WebPageProxy::computePagesForPrintingiOS):\n(WebKit::WebPageProxy::drawToPDFiOS):\n(WebKit::WebPageProxy::drawToImage):\n* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:\n(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):\n\nCanonical link: https://commits.webkit.org/280352@main","shortMessageHtmlLink":"[Site Isolation] Reduce use of legacyMainFrameProcess"}},{"before":"047f0dfa29993b617b47f042fe1b458a30cad1fd","after":"59950b920418413ba9bd7e6bfca147bd599d0514","ref":"refs/heads/eng/WebGPU-Release-assertion-triggered-in-RenderPassEncodercomputeMininumVertexInstanceCount","pushedAt":"2024-06-24T20:56:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"webkit-commit-queue","name":"Commit Queue","path":"/webkit-commit-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77073439?s=80&v=4"},"commit":{"message":"[WebGPU] Release assertion triggered in RenderPassEncoder::computeMininumVertexInstanceCount\nhttps://bugs.webkit.org/show_bug.cgi?id=275569\n<radar://129990531>\n\nReviewed by Tadeu Zagallo.\n\nIf the user does not call setVertexBuffer on a buffer which the pipeline\nuses, we should treat the buffer's size as 0.\n\n* LayoutTests/fast/webgpu/nocrash/poc-275569-expected.txt: Added.\n* LayoutTests/fast/webgpu/nocrash/poc-275569.html: Added.\nAdd regression test.\n\n* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:\n(WebGPU::RenderBundleEncoder::computeMininumVertexInstanceCount const):\n* Source/WebGPU/WebGPU/RenderPassEncoder.mm:\n(WebGPU::RenderPassEncoder::computeMininumVertexInstanceCount const):\n\nCanonical link: https://commits.webkit.org/280310@main","shortMessageHtmlLink":"[WebGPU] Release assertion triggered in RenderPassEncoder::computeMin…"}},{"before":"7b4b228db2406c5020b9a5561cc44c60c3b70643","after":"e7fdac7081ef8d5c56e987ad098763ff2b09ac26","ref":"refs/heads/eng/WebGPU-Integer-overflows-in-validateResolveQuerySet","pushedAt":"2024-06-24T17:06:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"webkit-commit-queue","name":"Commit Queue","path":"/webkit-commit-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77073439?s=80&v=4"},"commit":{"message":"[WebGPU] Integer overflows in validateResolveQuerySet\nhttps://bugs.webkit.org/show_bug.cgi?id=275620\n<radar://130058905>\n\nReviewed by Dan Glastonbury.\n\nA compromised web process could overflow the calculations in\nvalidateResolveQuerySet().\n\n* Source/WebGPU/WebGPU/CommandEncoder.mm:\n(WebGPU::validateResolveQuerySet):\n\nCanonical link: https://commits.webkit.org/280306@main","shortMessageHtmlLink":"[WebGPU] Integer overflows in validateResolveQuerySet"}},{"before":null,"after":"7961c445d1ab90f6e37da3e9b83f3d07592710b7","ref":"refs/heads/eng/WebGL-Allocate-PixelBuffer-for-read-back-in-web-process","pushedAt":"2024-06-21T23:48:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"}},{"before":"fc13fa9398649ea9eb1034d84905b6db1ff65dc8","after":"e127c6bb3b51fa1c5b2448c44f64d512f3aa7cd0","ref":"refs/heads/main","pushedAt":"2024-06-21T23:48:23.000Z","pushType":"push","commitsCount":63,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"Make WebBackForwardCache's m_itemsWithCachedPage more robust\nhttps://bugs.webkit.org/show_bug.cgi?id=275744\nrdar://129706255\n\nReviewed by Alex Christensen.\n\nUse a WeakListHashSet instead of a Vector<WeakPtr<>> for m_itemsWithCachedPage.\nThis is less error-prone as it will avoid crashes if a WebBackForwardList item\ngets destroyed without unregistering itself from the WebBackForwardListCache\nfirst.\n\nThis should avoid crashes such as in rdar://129706255.\n\n* Source/WebKit/UIProcess/WebBackForwardCache.cpp:\n(WebKit::WebBackForwardCache::addEntry):\n(WebKit::WebBackForwardCache::removeEntry):\n(WebKit::WebBackForwardCache::takeSuspendedPage):\n(WebKit::WebBackForwardCache::removeEntriesMatching):\n(WebKit::WebBackForwardCache::clear):\n* Source/WebKit/UIProcess/WebBackForwardCache.h:\n\nCanonical link: https://commits.webkit.org/280264@main","shortMessageHtmlLink":"Make WebBackForwardCache's m_itemsWithCachedPage more robust"}},{"before":"758ab02bc65804f1c47a8b55ed21415552a5084b","after":"95f95344fbdd5f0a09132ae183083a2496c761ab","ref":"refs/heads/eng/WebGPU-Metal-compiler-error-message-can-expose-privacy-sensitive-information","pushedAt":"2024-06-20T16:05:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"webkit-commit-queue","name":"Commit Queue","path":"/webkit-commit-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77073439?s=80&v=4"},"commit":{"message":"[WebGPU] Metal compiler error message can expose privacy sensitive information\nhttps://bugs.webkit.org/show_bug.cgi?id=275624\n<radar://130065215>\n\nReviewed by Dan Glastonbury.\n\nMetal compilation error message was leaking privacy sensitive information.\n\n* LayoutTests/TestExpectations:\nSkip for debug as we print privacy sensitive information in debug.\n\n* LayoutTests/fast/webgpu/regression/repro_275624-expected.txt: Added.\n* LayoutTests/fast/webgpu/regression/repro_275624.html: Added.\nAdd regression test.\n\n* Source/WebGPU/WebGPU/ShaderModule.mm:\n(WebGPU::ShaderModule::createLibrary):\n\nCanonical link: https://commits.webkit.org/280202@main","shortMessageHtmlLink":"[WebGPU] Metal compiler error message can expose privacy sensitive in…"}},{"before":null,"after":"2e6ca87521324718d852a561c570ca9d9dce0ae4","ref":"refs/heads/eng/WebGPU-errorValidatingDynamicOffsets-can-be-bypassed-in-setBindGroup","pushedAt":"2024-06-20T16:03:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"}},{"before":"4960abc4c6b70429c02166e1242ccee57f36fdb6","after":"fc13fa9398649ea9eb1034d84905b6db1ff65dc8","ref":"refs/heads/main","pushedAt":"2024-06-20T16:03:27.000Z","pushType":"push","commitsCount":60,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"Implement more CheckedNumerics in RenderPassEncoder\nhttps://bugs.webkit.org/show_bug.cgi?id=275618\nrdar://130085918\n\nReviewed by Mike Wyrzykowski.\n\nIncrease the usage of CheckedNumerics in RenderPassEncoder\n\n* Source/WebGPU/WebGPU/RenderPassEncoder.mm:\n(WebGPU::RenderPassEncoder::runVertexBufferValidation):\n(WebGPU::RenderPassEncoder::incrementDrawCount):\n(WebGPU::RenderPassEncoder::executePreDrawCommands):\n(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):\n(WebGPU::RenderPassEncoder::drawIndexed):\n(WebGPU::RenderPassEncoder::drawIndexedIndirect):\n(WebGPU::RenderPassEncoder::drawIndirect):\n(WebGPU::RenderPassEncoder::errorValidatingPipeline const):\n(WebGPU::RenderPassEncoder::setScissorRect):\n\nCanonical link: https://commits.webkit.org/280201@main","shortMessageHtmlLink":"Implement more CheckedNumerics in RenderPassEncoder"}},{"before":"940219a883e0275b87426e41aae9e50fc8e1e07d","after":"758ab02bc65804f1c47a8b55ed21415552a5084b","ref":"refs/heads/eng/WebGPU-Metal-compiler-error-message-can-expose-privacy-sensitive-information","pushedAt":"2024-06-18T23:12:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"}},{"before":"de1667dea3dd915fbd6610e7ffc94a7b23a3b29c","after":"4960abc4c6b70429c02166e1242ccee57f36fdb6","ref":"refs/heads/main","pushedAt":"2024-06-18T23:11:51.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"Crash at WebKit::WebExtensionDynamicScripts::WebExtensionRegisteredScript::removeUserScripts.\nhttps://webkit.org/b/275637\nrdar://130111574\n\nReviewed by Brian Weinstein.\n\n* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIScriptingCocoa.mm:\n(WebKit::WebExtensionContext::scriptingUnregisterContentScripts): Null-check the result of take()\nsince the scriptID might not be valid anymore, and it wont be found in the HashMap.\n\nCanonical link: https://commits.webkit.org/280141@main","shortMessageHtmlLink":"Crash at WebKit::WebExtensionDynamicScripts::WebExtensionRegisteredSc…"}},{"before":"1f51e7a1b31a85b30beb99904185a79e1832fb6d","after":"e999bcebefdcbbfd16744dc545413c2cacc31ed3","ref":"refs/heads/eng/CTS-apivalidationencodingcmdsrender-test-is-failing","pushedAt":"2024-06-18T18:39:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"webkit-commit-queue","name":"Commit Queue","path":"/webkit-commit-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77073439?s=80&v=4"},"commit":{"message":"CTS api,validation,encoding,cmds,render,* test is failing\nhttps://bugs.webkit.org/show_bug.cgi?id=275513\n<radar://129874785>\n\nReviewed by Tadeu Zagallo.\n\n279708@main introduced incorrect validation for invalid draw calls,\ninstead of reverting it which would reintroduce the buffer overflow,\ncorrect the logic so invalid draws produce the expected validation error.\n\nAlso enable the impacted test to avoid regressing the CTS test moving\nforwards.\n\n* LayoutTests/fast/webgpu/regression/repro_275024-expected.txt:\n* LayoutTests/fast/webgpu/regression/repro_275024b-expected.txt:\nUpdate expectations, this case should not be a validation error per\nthe specification.\n\n* LayoutTests/platform/mac-wk2/TestExpectations:\nAdd test to passing list.\n\n* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:\n(WebGPU::RenderBundleEncoder::executePreDrawCommands):\n(WebGPU::RenderBundleEncoder::computeMininumVertexInstanceCount const):\n* Source/WebGPU/WebGPU/RenderPassEncoder.mm:\n(WebGPU::RenderPassEncoder::executePreDrawCommands):\n(WebGPU::RenderPassEncoder::computeMininumVertexInstanceCount const):\nCorrect logic.\n\nCanonical link: https://commits.webkit.org/280129@main","shortMessageHtmlLink":"CTS api,validation,encoding,cmds,render,* test is failing"}},{"before":"8705d36f2531620db3d6d8af2135a21dbfcc74bf","after":"1f51e7a1b31a85b30beb99904185a79e1832fb6d","ref":"refs/heads/eng/CTS-apivalidationencodingcmdsrender-test-is-failing","pushedAt":"2024-06-18T18:37:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"webkit-commit-queue","name":"Commit Queue","path":"/webkit-commit-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77073439?s=80&v=4"}},{"before":null,"after":"940219a883e0275b87426e41aae9e50fc8e1e07d","ref":"refs/heads/eng/WebGPU-Metal-compiler-error-message-can-expose-privacy-sensitive-information","pushedAt":"2024-06-18T18:28:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"}},{"before":"8930049ceecd1c421783172cc234a0cbe3eab94d","after":"de1667dea3dd915fbd6610e7ffc94a7b23a3b29c","ref":"refs/heads/main","pushedAt":"2024-06-18T18:28:38.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"mwyrzykowski","name":null,"path":"/mwyrzykowski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105083895?s=80&v=4"},"commit":{"message":"Context Menu shows Exit Full Screen instead of Exit Viewer\nhttps://bugs.webkit.org/show_bug.cgi?id=275460\nrdar://126300924\n\nReviewed by Jer Noble.\n\nThis patch adds a context menu item to video elements\nthat enters and exits Viewer mode. This patch also\nremoves the toggle fullscreen context menu item when\nthe video is in Viewer mode.\n\n* Source/WebCore/en.lproj/Localizable.strings:\n* Source/WebCore/page/ContextMenuController.cpp:\n(WebCore::ContextMenuController::contextMenuItemSelected):\n(WebCore::ContextMenuController::populate):\n(WebCore::ContextMenuController::checkOrEnableIfNeeded const):\n* Source/WebCore/platform/ContextMenuItem.cpp:\n(WebCore::isValidContextMenuAction):\n* Source/WebCore/platform/ContextMenuItem.h:\n* Source/WebCore/platform/LocalizedStrings.h:\n* Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:\n(WebCore::contextMenuItemTagEnterVideoViewer):\n(WebCore::contextMenuItemTagExitVideoViewer):\n* Source/WebCore/rendering/HitTestResult.cpp:\n(WebCore::HitTestResult::mediaIsInVideoViewer const):\n(WebCore::HitTestResult::toggleVideoViewer const):\n* Source/WebCore/rendering/HitTestResult.h:\n* Source/WebKit/Shared/API/c/WKContextMenuItemTypes.h:\n* Source/WebKit/Shared/API/c/WKSharedAPICast.h:\n(WebKit::toAPI):\n(WebKit::toImpl):\n* Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:\n* Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:\n* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:\n(WebKit::menuItemIdentifier):\n* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:\n(toAction):\n(toTag):\n* Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h:\n\nCanonical link: https://commits.webkit.org/280128@main","shortMessageHtmlLink":"Context Menu shows Exit Full Screen instead of Exit Viewer"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEdR6V9wA","startCursor":null,"endCursor":null}},"title":"Activity · mwyrzykowski/WebKit"}