Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up scapegoat to 1.3.7. #100

Merged
merged 3 commits into from Aug 19, 2018
Merged

Bump up scapegoat to 1.3.7. #100

merged 3 commits into from Aug 19, 2018

Conversation

@mwz
Copy link
Owner

mwz commented Aug 16, 2018

I bumped up some dependencies including Scapegoat, which adds a new inspection - UnsafeStringContains.

I created a separate issue to upgrade FastClasspathScanner to the latest version as there are some breaking changes (#99).

Closes #86.

@mwz mwz added this to In progress in sonar-scala via automation Aug 16, 2018
@BalmungSan

This comment has been minimized.

Copy link
Contributor

BalmungSan commented Aug 17, 2018

Hi @mwz, Nice.

Should we Bump SBT to 1.2.1 too?

PS: Sorry about the unused imports in the ScapegoatInspectionsGeneratorTask

@mwz

This comment has been minimized.

Copy link
Owner Author

mwz commented Aug 18, 2018

Should we Bump SBT to 1.2.1 too?

Yeah, sorry I missed it - I bumped it up in the last commit.

PS: Sorry about the unused imports in the ScapegoatInspectionsGeneratorTask

No worries 👍

@BalmungSan

This comment has been minimized.

Copy link
Contributor

BalmungSan commented Aug 18, 2018

👍

@mwz mwz merged commit 2688cd0 into master Aug 19, 2018
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
sonar-scala automation moved this from In progress to Done Aug 19, 2018
@mwz mwz deleted the scapegoat-1.3.7 branch Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
sonar-scala
  
Done
2 participants
You can’t perform that action at this time.