Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding the Scalastyle+Scapegoat Quality Profile. #112
This is a Proof of Concept of how we could implement the Scalastyle+Scapegoat Quality Profile.
I want to note two important things:
I'll stay tuned to any comments.
That's great @BalmungSan, looks good to me!
Re 1: I'm almost 100% sure that we'll want to adjust rule severity, blacklist some of the active rules and even potentially create new instances of Scalastyle templates, so we'll need to come up with a good mechanism that will allow us to create a quality profile that we can both be happy about and consider to be the best possible combination of Scalastyle and Scapegoat rules.
This PR gets the job done for the Scalastyle + Scapegoat quality profile, but I have a feeling that we'll need to refactor things a bit in order to set up our recommended profile. But let's merge this PR for now and we can move the discussion about this to #80.
Re 2: I'm not entirely sure what you mean by Stringly Typed, would you mind expanding on this?
Oh, sorry, it's a term I heard in a Scala conference and I started using it without noticing. Basically it means using Strings for everything (pun intended with Strongly Typed) - Most common example, being a Database schema where each field, except for the PK, is a VARCHAR255.
Regarding sonar-scala recomended profile, I will start a discussion about it in #80.