Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube 7.3 #120

Merged
merged 9 commits into from Oct 8, 2018
Merged

SonarQube 7.3 #120

merged 9 commits into from Oct 8, 2018

Conversation

@mwz
Copy link
Owner

mwz commented Sep 30, 2018

With this PR our master branch will become where we develop against the latest SonarQube and the existing 6.x series (for SonarQube 6.7 LTS) will be maintained on a separate branch.

This is not yet ready to be merged, I'm just opening the PR for visibility.

Closes #11 and #7.

Copy link
Contributor

BalmungSan left a comment

😎 💣

@@ -36,7 +36,7 @@ sourceGenerators in Compile ++= Seq(
)

// Lib dependencies
val sonarVersion = "6.7"
val sonarVersion = "7.3"
libraryDependencies ++= List(

This comment has been minimized.

Copy link
@BalmungSan

BalmungSan Sep 30, 2018

Contributor

I remember, I once said that when we refactor the old scalastyle module, there will be some dependencies we could remove... I think they were sonar-core and guava, but I'm not 100% sure. I will try to search for that discussion after the review. But if I couldn't find it, could you please try removing some dependencies and check if we don't need?

EDIT
I found it! 🕵️

@BalmungSan

This comment has been minimized.

Copy link
Contributor

BalmungSan commented Sep 30, 2018

Nice, I think we could remove this file too? - or did I get wrong your previous explanation?
Also, I almost sure this will close #7 too, or ar we missing something? (PS: I don't know if github allow to close multiple issues with one PR automatically, so we don't have to do it manually).

@mwz

This comment has been minimized.

Copy link
Owner Author

mwz commented Sep 30, 2018

Nice, I think we could remove this file too? - or did I get wrong your previous explanation?

It is actually used by the LogSpec and I guess we could also use in other places for testing logging, so we should keep it.

Also, I almost sure this will close #7 too, or ar we missing something? (PS: I don't know if github allow to close multiple issues with one PR automatically, so we don't have to do it manually).

I'm not sure either, but I'll add reference in the description.

Copy link
Contributor

BalmungSan left a comment

Great!

@mwz mwz changed the title WIP SonarQube 7.3 SonarQube 7.3 Oct 1, 2018
@mwz

This comment has been minimized.

Copy link
Owner Author

mwz commented Oct 1, 2018

I've tested this on example projects and sonar-scala and everything works as expected - I think this PR is ready to be merged. I'll prepare release notes and update readme in a separate PR.

@mwz

This comment has been minimized.

Copy link
Owner Author

mwz commented Oct 1, 2018

Should we also bump the default version of Scala up to 2.12 as a part of this release?

@BalmungSan

This comment has been minimized.

Copy link
Contributor

BalmungSan commented Oct 1, 2018

"Should we also bump the default version of Scala up to 2.12 as a part of this release?"

I think yes, we should.

@BalmungSan

This comment has been minimized.

Copy link
Contributor

BalmungSan commented Oct 4, 2018

Nice.
So, are you releasing after the checks complete? - or what else you want to do?

@mwz

This comment has been minimized.

Copy link
Owner Author

mwz commented Oct 4, 2018

So, are you releasing after the checks complete? - or what else you want to do?

No, I think that's it for now - I'll go ahead and make the release shortly!

@mwz mwz merged commit ecbc673 into master Oct 8, 2018
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
@mwz mwz deleted the sonar-7.3 branch Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.