Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube 7.4 #127

Merged
merged 2 commits into from Nov 19, 2018
Merged

SonarQube 7.4 #127

merged 2 commits into from Nov 19, 2018

Conversation

@mwz
Copy link
Owner

mwz commented Nov 11, 2018

Bump up SonarQube to 7.4.

@mwz mwz changed the title SonarQube to 7.4. SonarQube 7.4. Nov 11, 2018
@mwz mwz changed the title SonarQube 7.4. SonarQube 7.4 Nov 11, 2018
@mwz mwz added this to In progress in sonar-scala via automation Nov 11, 2018
@mwz mwz added the sonarqube label Nov 11, 2018
Copy link
Contributor

BalmungSan left a comment

👍
I liked the line end offsets, it makes more clear how it works - is that method new in 7.x ?, I don't remember it.

@@ -5,6 +5,8 @@ align {
openParenCallSite = false
openParenDefnSite = false
tokens.add = [
"%",
"%%"

This comment has been minimized.

Copy link
@BalmungSan

BalmungSan Nov 12, 2018

Contributor

I haven't used scalafmt before, but aren't you missing a comma (',') at the end of this line?

This comment has been minimized.

Copy link
@mwz

mwz Nov 12, 2018

Author Owner

oh, yes

@mwz

This comment has been minimized.

Copy link
Owner Author

mwz commented Nov 12, 2018

is that method new in 7.x ?, I don't remember it.

Looks like they just removed setOriginalLineOffsets from the API in 7.4 and replaced it with setOriginalLineStartOffsets and setOriginalLineEndOffsets.

@mwz mwz merged commit e86f562 into master Nov 19, 2018
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
sonar-scala automation moved this from In progress to Done Nov 19, 2018
@mwz mwz deleted the sonar-7.4 branch Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
sonar-scala
  
Done
2 participants
You can’t perform that action at this time.