Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport features from 7.x #136

Merged
merged 6 commits into from Dec 8, 2018
Merged

Backport features from 7.x #136

merged 6 commits into from Dec 8, 2018

Conversation

@mwz
Copy link
Owner

mwz commented Dec 4, 2018

Backporting features from 7.x - includes the recommended quality profile, updated generation of Scapegoat rules, version bumps and other minor tweaks.

mwz added 3 commits Dec 3, 2018
@@ -1 +1 @@
sbt.version = 1.2.3
sbt.version = 1.2.6

This comment has been minimized.

Copy link
@BalmungSan

BalmungSan Dec 4, 2018

Contributor

We are already in sbt 1.2.7.

@@ -42,6 +42,6 @@ private[scapegoat] final case class ScapegoatInspection(
defaultLevel: Level
)

private[scapegoat] object ScapegoatInspections {
object ScapegoatInspections {

This comment has been minimized.

Copy link
@BalmungSan

BalmungSan Dec 4, 2018

Contributor

Why made it public ?
With the work you did in #130 this can be _private to the scapegoat package, the same can go with the ScalastyleInspections object.

This comment has been minimized.

Copy link
@mwz

mwz Dec 5, 2018

Author Owner

Looks like I missed it after refactoring.

Copy link
Contributor

BalmungSan left a comment

Except for the detail with the ScapegoatInspections object, this looks great.

mwz added 3 commits Dec 5, 2018
@mwz mwz merged commit 94ddc77 into sonar-6.7-lts Dec 8, 2018
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
@mwz mwz deleted the backport-from-7.x branch Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.