Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor scoverage plugin #34
Note: Breaking change.
This PR changes a lot of things, so it should be reviewed carefully, also I suggest to test it before merging.
I had made the changes you suggested, except for the metrics one, see my comment for a discussion about it.
I ended using the
Additionally, I had already tested the plugin with a multi-module project and it worked perfectly (after some minor changes)
So, I think the PR is now ready to merge, unless you had other suggestions.
I've just run analysis on your branch using a local snapshot of the plugin and everything looks good to me. I've noticed that the project statement coverage which previously appeared under the Test section in Measures now shows up under Coverage -> Tests which is probably a much better place for it
Also well done for increasing project coverage to ~89%
If I understood you well, you just analyzed this branch with the compiled plugin from this branch, wow that's what I call sonar-ception
Ok, leaving the bad jokes aside, I would like to thank you once again for taking all the time for this review.
I will make the final changes tomorrow and this would be ready for merge!
Haha, yes it's almost like bootstrapping a compiler :)
Thank you for doing this massive refactor, I feel like this was a very good call and your changes are definitely going to make it easier to maintain this plugin and implement new features going forward!