Skip to content

Widget fails on artists with & in the title #2

Closed
subpop opened this Issue Nov 15, 2009 · 3 comments

2 participants

@subpop
subpop commented Nov 15, 2009

Case in point, when playing Simon & Garfunkel, the widget loads the artist "Simon". This can be fixed by escaping the variable artist in the url definition on line 55.

var url = "http://ws.audioscrobbler.com/2.0/?callback=artist_got_info&method=artist.getinfo&api_key=b25b959554ed76058ac220b7b2e0a026&artist="+escape(artist)+"&format=json";

@mxcl
Owner
mxcl commented Nov 15, 2009

How embarrassing! Thanks.

@subpop
subpop commented Nov 15, 2009

Not at all. It happens, and that's what's great about open source software. You can have people QA it from all over the place, with all sorts of usage scenarios. I've already fixed my local copy, and providing the solution in the bug report makes the job of the developer that much easier. Glad to contribute. :)

@mxcl
Owner
mxcl commented Nov 15, 2009

Closed by bef1c3a; Widget doesn't work with & symbols

We weren't escaping the special characters in the URL before requesting that URL from Last.fm. So Simon & Garfunkel didn't work for example.

Somewhat embarassed about this mistake…!

@waldirbertazzijr waldirbertazzijr pushed a commit to waldirbertazzijr/Audioscrobbler.app that referenced this issue Dec 22, 2014
@mxcl Fixes #2; Widget doesn't work with & symbols
We weren't escaping the special characters in the URL before requesting that URL from Last.fm. So Simon & Garfunkel didn't work for example.

Somewhat embarassed about this mistake…!
bef1c3a
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.