New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NSURL in docs #656

Merged
merged 3 commits into from May 17, 2017

Conversation

2 participants
@zlangley
Collaborator

zlangley commented Apr 25, 2017

No description provided.

@zlangley zlangley requested a review from mxcl Apr 25, 2017

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Apr 26, 2017

Owner

Thing is though. It still is NSURLEtc for ObjC. And for Google juice. Dunno yet what should be chosen for non code samples.

Owner

mxcl commented Apr 26, 2017

Thing is though. It still is NSURLEtc for ObjC. And for Google juice. Dunno yet what should be chosen for non code samples.

@zlangley

This comment has been minimized.

Show comment
Hide comment
@zlangley

zlangley Apr 26, 2017

Collaborator

I think all the changes made are either in Swift code or associated with Swift code.

Collaborator

zlangley commented Apr 26, 2017

I think all the changes made are either in Swift code or associated with Swift code.

Show outdated Hide outdated README.markdown
Show outdated Hide outdated Sources/AnyPromise.h
@zlangley

Ack, just seeing your comments now.

Show outdated Hide outdated README.markdown
Show outdated Hide outdated Sources/AnyPromise.h

@mxcl mxcl merged commit c3be8eb into master May 17, 2017

3 of 4 checks passed

codecov/project 90.45% (-0.05%) compared to cfae62d
Details
codecov/patch Coverage not affected when comparing cfae62d...4ff3084
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mxcl mxcl deleted the url-docs branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment