New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift #923

Merged
merged 2 commits into from Sep 23, 2018

Conversation

2 participants
@heyzooi
Contributor

heyzooi commented Sep 19, 2018

Updating Package.swift to add support for Swift 4.2

Update Package.swift
Updating Package.swift to add support for Swift 4.2
@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 20, 2018

Owner

This breaks our support for some Swift versions

Owner

mxcl commented Sep 20, 2018

This breaks our support for some Swift versions

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 20, 2018

Owner

I saw IBM doing something where they specify Package@4.0.swift or something, I wonder if that is legal?

Owner

mxcl commented Sep 20, 2018

I saw IBM doing something where they specify Package@4.0.swift or something, I wonder if that is legal?

@heyzooi

This comment has been minimized.

Show comment
Hide comment
@heyzooi

heyzooi Sep 20, 2018

Contributor

@mxcl it seems possible... https://github.com/apple/swift-protobuf/blob/master/Package%40swift-4.2.swift

I will try that soon and push new commits to this PR

Contributor

heyzooi commented Sep 20, 2018

@mxcl it seems possible... https://github.com/apple/swift-protobuf/blob/master/Package%40swift-4.2.swift

I will try that soon and push new commits to this PR

Repository owner deleted a comment from codecov bot Sep 21, 2018

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 21, 2018

Owner

Would be good if we can add a travis test to verify we are actually getting 4.2 out of the swift compiler. If you can't think of a way, I'll merge and I can try to figure it out at a later time.

Owner

mxcl commented Sep 21, 2018

Would be good if we can add a travis test to verify we are actually getting 4.2 out of the swift compiler. If you can't think of a way, I'll merge and I can try to figure it out at a later time.

@heyzooi

This comment has been minimized.

Show comment
Hide comment
@heyzooi

heyzooi Sep 21, 2018

Contributor

@mxcl I'm not sure how this could be done. One way maybe would be replace the swiftLanguageVersions to the old format [3, 4] and check if it fails. Do you have any suggestion how to do it?

Contributor

heyzooi commented Sep 21, 2018

@mxcl I'm not sure how this could be done. One way maybe would be replace the swiftLanguageVersions to the old format [3, 4] and check if it fails. Do you have any suggestion how to do it?

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 23, 2018

Owner

Seems like making a test Package.swift that depends on ours could specify other variants. But I can do it.

Owner

mxcl commented Sep 23, 2018

Seems like making a test Package.swift that depends on ours could specify other variants. But I can do it.

@mxcl mxcl merged commit 4cd8a0d into mxcl:master Sep 23, 2018

3 checks passed

codecov/patch Coverage not affected when comparing a06c705...ded2f5a
Details
codecov/project 96.6% remains the same compared to a06c705
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 23, 2018

Owner

I published 6.4.1

Owner

mxcl commented Sep 23, 2018

I published 6.4.1

@heyzooi heyzooi deleted the heyzooi:patch-1 branch Sep 24, 2018

dougzilla32 added a commit to dougzilla32/PromiseKit that referenced this pull request Oct 6, 2018

Update Package.swift (mxcl#923)
* Update Package.swift

Updating Package.swift to add support for Swift 4.2

* adding support for Swift 4.2 without break support for older versions of Swift 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment