New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `final` where possible #956

Merged
merged 2 commits into from Nov 7, 2018

Conversation

1 participant
@mxcl
Owner

mxcl commented Nov 7, 2018

No description provided.

mxcl added some commits Nov 7, 2018

Use `final` where possible
Allows the optimizer to remove dynamic dispatch, being `public` rather than `open` is not enough.

https://twitter.com/mxcl/status/1060222414829838336

@mxcl mxcl merged commit ff97aa9 into master Nov 7, 2018

3 checks passed

codecov/patch Coverage not affected when comparing a4b4de8...41699e2
Details
codecov/project 96.9% remains the same compared to a4b4de8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mxcl mxcl deleted the final branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment