Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"http://" and port number forced on feed xml addresses #47

Closed
bartlibert opened this issue Nov 18, 2019 · 3 comments
Closed

"http://" and port number forced on feed xml addresses #47

bartlibert opened this issue Nov 18, 2019 · 3 comments

Comments

@bartlibert
Copy link

@bartlibert bartlibert commented Nov 18, 2019

I have podsync running on my own server behind nginx, with https enabled.
This means it is available at "https://podsync.myserver.net". However, the xml feed contains references to "http://podsync.myserver.net:9090/", which does not work for two reasons: it does not use ssl, which is required on my server + port 9090 is not exposed, the "podsync" subdomain just redirects to it.

@mxpv

This comment has been minimized.

Copy link
Owner

@mxpv mxpv commented Nov 19, 2019

That's the opposite to #43
Probably port and hostname should be independent.
So it'd be possible to cover both cases:

port=8080
hostname=http://myserver:8080

and for cases with frontend

port=8080
hostname=https://myserver.net (nginx redirects to `http://localhost:8080`)

It might also make sense to embed https functionality (for instance with automatic Let's encrypt).

@bartlibert

This comment has been minimized.

Copy link
Author

@bartlibert bartlibert commented Nov 19, 2019

This seems a good solution. Maybe make the builtin Let's encrypt support optional, as it might interfere with nginx encryption (not sure?)?

@mxpv

This comment has been minimized.

Copy link
Owner

@mxpv mxpv commented Nov 20, 2019

@bartlibert for sure, it must be optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.