Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] In multi-OS matrixes action fails #3

Open
webknjaz opened this issue Sep 6, 2019 · 4 comments
Labels

Comments

@webknjaz
Copy link

@webknjaz webknjaz commented Sep 6, 2019

If I just add this step to the matrix, it crashes non-Linux workers which lead to auto-cancellation of all the jobs.

Workaround: make the action step conditional.

Fix: we could change it to be noop under mac/windows. It would be better to use homebrew to install tmate under mac, though and maybe research whether anybody hacked it to work under windows.

@mxschmitt

This comment has been minimized.

Copy link
Owner

@mxschmitt mxschmitt commented Sep 6, 2019

Good catch @webknjaz. I will investigate once I've time.

@mxschmitt

This comment has been minimized.

Copy link
Owner

@mxschmitt mxschmitt commented Oct 31, 2019

The macOS part is now done, thanks to @shouze. For Windows I think we can simply do a noop action and print only out a warning or something like that.

@webknjaz

This comment has been minimized.

Copy link
Author

@webknjaz webknjaz commented Oct 31, 2019

Maybe report an error with some explanation via Checks API?

@webknjaz

This comment has been minimized.

Copy link
Author

@webknjaz webknjaz commented Oct 31, 2019

FWIW I think the README should contain a warning explaining that it doesn't support Windows too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.