New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make node-leveldb ready for node 0.8.x #38
Conversation
…ion for coffee-script now
Mocha fixes
modified leveldb.gyp to build a static_library
I've submitted a pull request to pconstr that fixes this. Afterwards it npm installs! |
don't delete the build dir, it's needed
The title is misleading, node-leveldb works fine for me on Node.js 0.8.3. I think the main advantage of node-gyp is Windows support? Speaking of which, I'm maintaining a Windows branch of leveldb - using this with minimal changes it should be possible to make this module compile on Windows. I might have a go at it if I have some time and there is interest. |
Long story short, it does not work under OS X if you install the node.js binaries instead of compiling them yourself. Gyp magically makes these problems go away. |
Ok, I've done some testing. This pull request currently disables Snappy, which is a regression imho. So I've created a new pull here: #39. Would be awesome if you guys could test that one and see if it works for you. I'll leave this one open until I get some feedback on the new one. (Technically, we could merge this one first. Then mine would be simply a pull to update the deps and reenable Snappy.) |
I agree removing Snappy is less than ideal and if you have a fix might as well just do it all together. Testing... |
good point, let's not drop Snappy |
People seem to be in agreement on keeping Snappy, closing in favor of #39. |
includes commits from https://github.com/gflarity with thanks to https://github.com/AvianFlu
tests pass: http://travis-ci.org/#!/pconstr/node-leveldb