Alex Coles
myabc

Organizations

@datamapper @eurucamp @livingstyleguide @rubyberlin @goskive @rom-rb
Aug 19, 2016
@myabc
Support for Active Record 5
4 commits with 10 additions and 9 deletions
Aug 19, 2016
Aug 18, 2016
@myabc
  • @myabc 0c9d021
    DRY up: Extract #remove_index override into Module
Aug 17, 2016
@myabc
  • @myabc 1b4cfee
    Bump tested Ruby to 2.3.1
Aug 17, 2016
myabc commented on pull request SchemaPlus/schema_plus_indexes#4
@myabc

@ronen I think this is an issue with schema_dev. This project's Gemfile specifies ~> 5.0.

myabc deleted branch fix-activerecord-dependency at myabc/schema_plus_core
Aug 17, 2016
Aug 16, 2016
@myabc

@ronen This doesn't look right to me, now that Active Record 4.2 is no longer supported. Proposed fix here: #15

Aug 16, 2016
@myabc
Tighten up Active Record dependency
1 commit with 1 addition and 1 deletion
Aug 16, 2016
myabc commented on pull request SchemaPlus/schema_plus_indexes#4
@myabc

@ronen I think this is now ready for an initial review.

Aug 16, 2016
myabc commented on pull request SchemaPlus/schema_plus_indexes#4
@myabc

@ronen I'm not completely sure why the query returns auto-generated indexes here.

Aug 16, 2016
@myabc
Aug 16, 2016
@myabc
  • @myabc f0b08df
    Revert "Update deprecated #tables to #data_sources"
Aug 16, 2016
@myabc
Aug 16, 2016
myabc commented on pull request SchemaPlus/schema_plus_indexes#4
@myabc

Strange that enabled_middleware always returns false. Are you sure? (Actually it should return either a class or nil. See spec/support/enableable.rb

Aug 16, 2016
@myabc activerecord-5.0 is now 95d51a0
Aug 15, 2016
@myabc
  • @myabc 7f02db6
    Add Gemfile.local to test w/schema_plus_core fork
Aug 15, 2016
@myabc
  • @myabc 3f2d201
    Modify Rake travis task for schema_plus_core fork
Aug 15, 2016
myabc commented on pull request SchemaPlus/schema_plus_indexes#4
@myabc

@ronen Do you have a standard way of telling Travis to use a different upstream branch. I had considered configuring .travis.yml to write out a `Ge…

Aug 15, 2016
myabc commented on pull request SchemaPlus/schema_plus_indexes#4
@myabc

this allows the spec to pass, but is probably not the right solution: env.options[:index] = { name: 'whatever' } if enabled_middleware(AddIndexBefo…

Aug 15, 2016
myabc commented on pull request SchemaPlus/schema_plus_indexes#4
@myabc

@ronen I have specs passing locally for MySQL; PostgreSQL. SQLite3 still needs some work, hence the PR title (It's probably the RDBMS I'm least fam…

Aug 15, 2016
@myabc
  • @myabc cc6f01a
    Temp. switch to fork of schema_plus_core
Aug 14, 2016
@myabc
Activerecord 5.0
5 commits with 35 additions and 15 deletions
Aug 14, 2016
Aug 8, 2016
Aug 5, 2016
Aug 1, 2016
@myabc
  • @myabc c19509c
    Add new images to Step 3 too