Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

do parseInt so it doesn't depend on implicit conversion.

  • Loading branch information...
commit 18ccb5a23302fd7f772eb06141ad06d939513a9e 1 parent 88ef42b
@myakura authored
Showing with 7 additions and 4 deletions.
  1. +1 −1  manifest.json
  2. +6 −3 wkversion.js
View
2  manifest.json
@@ -1,6 +1,6 @@
{
"name": "Dicentra",
- "version": "0.2",
+ "version": "0.21",
"description": "enhances WebKit changeset page.",
"manifest_version": 2,
View
9 wkversion.js
@@ -3,12 +3,15 @@
rechangeset = /^https?:\/\/trac\.webkit\.org\/changeset\/(\d+)$/;
if (!rechangeset.test(url)) return;
- var revision = url.match(rechangeset)[1];
+ var revision = parseInt(url.match(rechangeset)[1], 10);
+
+ // looks like r25325 is the oldest revision
+ if (revision < 25325) return;
// path to Version.xcconfig
var pathtoconf = 'http://trac.webkit.org/export/' + revision + '/trunk/' +
- (revision >= 75314 ? 'Source/' : '') +
- 'WebCore/Configurations/Version.xcconfig';
+ (revision >= 75314 ? 'Source/' : '') +
+ 'WebCore/Configurations/Version.xcconfig';
var xhr = new XMLHttpRequest();
xhr.onload = function () {
Please sign in to comment.
Something went wrong with that request. Please try again.