From c596ae73cec555c9941d9b5b52a951b501f7270d Mon Sep 17 00:00:00 2001
From: Iwao AVE! <harawata@gmail.com>
Date: Mon, 8 May 2023 01:33:31 +0900
Subject: [PATCH] Undo invalid optimization with stronger comment

---
 .../org/apache/ibatis/migration/operations/ScriptRunner.java  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/ibatis/migration/operations/ScriptRunner.java b/src/main/java/org/apache/ibatis/migration/operations/ScriptRunner.java
index cf1f4cb0..90ec4d83 100644
--- a/src/main/java/org/apache/ibatis/migration/operations/ScriptRunner.java
+++ b/src/main/java/org/apache/ibatis/migration/operations/ScriptRunner.java
@@ -243,7 +243,9 @@ private void executeStatement(String command) throws SQLException {
       }
       try {
         boolean hasResults = statement.execute(sql);
-        while (hasResults || statement.getUpdateCount() != -1) {
+        // DO NOT try to 'imporove' the condition even if IDE tells you to!
+        // It's important that getUpdateCount() is called here.
+        while (!(!hasResults && statement.getUpdateCount() == -1)) {
           checkWarnings(statement);
           printResults(statement, hasResults);
           hasResults = statement.getMoreResults();